trigger staging cron when re-enabling staging on a branch #979
Labels
Comments
xmo-odoo
added a commit
that referenced
this issue
Nov 18, 2024
If staging gets re-enabled on a branch (or the branch itself gets re-enabled), immediately run a staging cron as there may already be PRs waiting, and no trigger enqueued: cron triggers have no payload, they just get removed when the cron runs which means if a bunch of PRs become ready for branch B with staging disabled, the cron is going to run, it's going to stage nothing on that branch (because staging is disabled) then it's going to delete all the triggers. Fixes #979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Though little used, a very long while back the ability to disable staging per branch was added to the mergebot. This is useful and nice.
However when crons were migrated to triggers, this was missed. So when re-enabling a branch it does not get staged even if there are ready PRs waiting.
On re-enabling a branch, we should immediately trigger the staging cron, in case where are ready PRs waiting.
The text was updated successfully, but these errors were encountered: