Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fw=no is not reflected in the PR dashboard #962

Open
xmo-odoo opened this issue Oct 9, 2024 · 0 comments
Open

fw=no is not reflected in the PR dashboard #962

xmo-odoo opened this issue Oct 9, 2024 · 0 comments
Labels
mergebot

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Oct 9, 2024

When setting fw=no on a PR, the dashboard table still shows up to the current master which is confusing.

reported by @rfr-odoo
@xmo-odoo xmo-odoo moved this to accepted in Mergebot Oct 9, 2024
@xmo-odoo xmo-odoo added this to Mergebot Oct 9, 2024
@xmo-odoo xmo-odoo moved this from accepted to done in Mergebot Oct 22, 2024
xmo-odoo added a commit that referenced this issue Oct 22, 2024
@xmo-odoo
[FIX] *: fw=no reflection in the PR dashboard
e7716f8 
Like limit, fw=no should restrict the table length, in this case to
just the current branch (as we're not forward porting at all).

Before this, `no` would not be applied as a limit visually, the table
would still go up to the main branch which is very confusing.

Fixes #962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mergebot
Projects
Mergebot
Status: done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xmo-odoo