Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback should work off of even sources #955

Open
xmo-odoo opened this issue Sep 23, 2024 · 1 comment
Open

feedback should work off of even sources #955

xmo-odoo opened this issue Sep 23, 2024 · 1 comment
Labels

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Sep 23, 2024

Technically we can get odd events from any source not just repositories proper, thus we may need to send feedback to any source. As such it would make sense for feedback to work off of sources.

  • there's no token associated to sources, so we may need tokens associated with sources (and / or sources associated with projects)
  • the repository id we currently send to needs to be remapped to source ids (maybe convert repository_id to a compute which translates to sources)
  • or maybe support sources in addition to repos? would be easier to migrate at least
@xmo-odoo xmo-odoo moved this to ideas in Mergebot Sep 23, 2024
@xmo-odoo xmo-odoo moved this from accepted to ideas in Mergebot Sep 27, 2024
@xmo-odoo
Copy link
Collaborator Author

After testing fine grained personal tokens a bit in case we'd have the (dumb) idea of using them:

  • the organisation owning the repository* needs to be opted into fine grained tokens (for coarse-grained PATs it's allowed by default although while setting up FGTs you can disable PAT access)
  • even though a user only needs read access to a repo to leave a comment on an issue or PR, FGTs need write access to the issue or PR, you know, cool shit, because when my bot is able to leave comments on a PR I definitely want it to be able to delete any other comment and close the fucking PR

I assume github hates FGTs and only implemented them due to popular demand, because holy crap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ideas
Development

No branches or pull requests

1 participant