Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set staging_end on staging cancel #931

Open
xmo-odoo opened this issue Aug 16, 2024 · 0 comments
Open

Set staging_end on staging cancel #931

xmo-odoo opened this issue Aug 16, 2024 · 0 comments
Labels
mergebot

Comments

@xmo-odoo
Copy link
Collaborator

The staging_end currently keeps running which is a bit odd.
@xmo-odoo xmo-odoo moved this to accepted in Mergebot Aug 16, 2024
@xmo-odoo xmo-odoo moved this from accepted to done in Mergebot Sep 6, 2024
xmo-odoo added a commit that referenced this issue Sep 6, 2024
@xmo-odoo
[FIX] runbot_merge: set staging_end on all terminations
146564a 
Rather than only setting `staging_end` on status change, set it when
the staging gets deactivated. This way cancelling a staging (whether
explicitely or via a PR update) will also end it, so will a staging
timeout, etc..., rather than keep the counter running.

Fixes #931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mergebot
Projects
Mergebot
Status: done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xmo-odoo