From ab539c109e22aee6d423d69d4d7323915bc36870 Mon Sep 17 00:00:00 2001 From: "Antoine (anso)" Date: Mon, 30 Sep 2024 18:26:45 +0200 Subject: [PATCH] [FIX] theme_bookstore: fix multiple issues in the theme This commit fixes multiples issues in the theme: - Wording - Shapes that should appear only in the configurator - Useless xpaths - Font bug in Firefox (-> texts have been outlined in the svg) task-4221731 --- .../static/description/theme_bookstore.svg | 46 +++++-------------- .../views/snippets/s_accordion.xml | 8 ++-- .../views/snippets/s_accordion_image.xml | 2 +- theme_bookstore/views/snippets/s_banner.xml | 16 +++++-- theme_bookstore/views/snippets/s_cover.xml | 6 +-- theme_bookstore/views/snippets/s_cta_box.xml | 16 +++++-- .../views/snippets/s_features_wall.xml | 2 +- .../views/snippets/s_key_images.xml | 2 +- theme_bookstore/views/snippets/s_showcase.xml | 5 -- theme_bookstore/views/snippets/s_title.xml | 15 ++++-- 10 files changed, 52 insertions(+), 66 deletions(-) diff --git a/theme_bookstore/static/description/theme_bookstore.svg b/theme_bookstore/static/description/theme_bookstore.svg index 1676f98866..32168b3a82 100644 --- a/theme_bookstore/static/description/theme_bookstore.svg +++ b/theme_bookstore/static/description/theme_bookstore.svg @@ -71,14 +71,10 @@ - - Section Title - + - - Discover - + @@ -87,9 +83,7 @@ - - Section Title - + @@ -104,10 +98,7 @@ - - Lorem ipsum dolor sit amet, consectetur adipiscing - elit. Praesent tristique fringilla. - + @@ -115,49 +106,37 @@ - - 04 - + - - 03 - + - - 02 - + - - 01 - + - - Section Title - + - - Discover - + @@ -169,10 +148,7 @@ - - Welcome - Message - + diff --git a/theme_bookstore/views/snippets/s_accordion.xml b/theme_bookstore/views/snippets/s_accordion.xml index 5be12f1099..dd76043ce5 100644 --- a/theme_bookstore/views/snippets/s_accordion.xml +++ b/theme_bookstore/views/snippets/s_accordion.xml @@ -14,17 +14,17 @@ We accept returns within 30 days of purchase, provided the book is in its original condition and accompanied by the receipt. Refunds will be issued in the original form of payment. Please note that certain items, like discounted or final sale items, may not be eligible for return. - + Do you offer gift cards? - + Yes, we offer both physical and digital gift cards in various amounts. Physical gift cards can be purchased in-store or online and shipped to the recipient, while digital gift cards are sent instantly via email. Both types can be used for online and in-store purchases. - + Can I request a book that's out of stock? - + Absolutely! If a book is out of stock, you can place a special order through our website or by visiting the store. We'll notify you once the book is back in stock, and you can choose to pick it up in-store or have it shipped to your address. Special orders typically take 1-2 weeks to fulfill, depending on availability. diff --git a/theme_bookstore/views/snippets/s_accordion_image.xml b/theme_bookstore/views/snippets/s_accordion_image.xml index 89fb7299ab..f1590b48e8 100644 --- a/theme_bookstore/views/snippets/s_accordion_image.xml +++ b/theme_bookstore/views/snippets/s_accordion_image.xml @@ -12,7 +12,7 @@ - Find quick answers to common questions about our books, services, and policies. + Find quick answers to common questions about our books, services and policies. diff --git a/theme_bookstore/views/snippets/s_banner.xml b/theme_bookstore/views/snippets/s_banner.xml index e5b7fb1848..b9ad2cce7d 100644 --- a/theme_bookstore/views/snippets/s_banner.xml +++ b/theme_bookstore/views/snippets/s_banner.xml @@ -5,11 +5,6 @@ - {'shape':'web_editor/Origins/14_001', 'colors':{'c3':'o-color-3','c4':'o-color-4'}, 'flip':[]} - - - -
@@ -32,4 +27,15 @@ + + diff --git a/theme_bookstore/views/snippets/s_cover.xml b/theme_bookstore/views/snippets/s_cover.xml index 5488dd6e3d..1147e83824 100644 --- a/theme_bookstore/views/snippets/s_cover.xml +++ b/theme_bookstore/views/snippets/s_cover.xml @@ -4,7 +4,7 @@ diff --git a/theme_bookstore/views/snippets/s_cta_box.xml b/theme_bookstore/views/snippets/s_cta_box.xml index 82f2f5433d..9e7e6633de 100644 --- a/theme_bookstore/views/snippets/s_cta_box.xml +++ b/theme_bookstore/views/snippets/s_cta_box.xml @@ -5,11 +5,6 @@ - {'shape':'web_editor/Origins/04_001', 'colors':{'c3':'o-color-4'}} - - - -
@@ -25,4 +20,15 @@ + + diff --git a/theme_bookstore/views/snippets/s_features_wall.xml b/theme_bookstore/views/snippets/s_features_wall.xml index a0f878053c..114a83e14a 100644 --- a/theme_bookstore/views/snippets/s_features_wall.xml +++ b/theme_bookstore/views/snippets/s_features_wall.xml @@ -15,7 +15,7 @@ - We also offer these additional services, always with the same passion and care that defines everything we do. + We also offer these additional services, always with the same passion and care that define everything we do. diff --git a/theme_bookstore/views/snippets/s_key_images.xml b/theme_bookstore/views/snippets/s_key_images.xml index 7f678da2c3..fb7a0bb03f 100644 --- a/theme_bookstore/views/snippets/s_key_images.xml +++ b/theme_bookstore/views/snippets/s_key_images.xml @@ -25,7 +25,7 @@
What I Didn't Post On Instagram
-

by Christy Stockton

+

by Chrissy Stockton

diff --git a/theme_bookstore/views/snippets/s_showcase.xml b/theme_bookstore/views/snippets/s_showcase.xml index af8681b07d..369c1af708 100644 --- a/theme_bookstore/views/snippets/s_showcase.xml +++ b/theme_bookstore/views/snippets/s_showcase.xml @@ -5,11 +5,6 @@ - {'shape':'web_editor/Origins/11_001', 'colors':{'c3':'o-color-4','c4':'o-color-5'}, 'flip':['y']} - - - -
diff --git a/theme_bookstore/views/snippets/s_title.xml b/theme_bookstore/views/snippets/s_title.xml index a4335a5c97..b3b0cefa40 100644 --- a/theme_bookstore/views/snippets/s_title.xml +++ b/theme_bookstore/views/snippets/s_title.xml @@ -12,10 +12,6 @@
- - -
-

The most beautiful things in the world cannot be seen or touched, they are felt with the heart.

@@ -23,4 +19,15 @@
+ +