Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort all keys and values alphabetically for easier diffs #5

Open
gr2m opened this issue Aug 25, 2020 · 0 comments
Open

Sort all keys and values alphabetically for easier diffs #5

gr2m opened this issue Aug 25, 2020 · 0 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@gr2m
Copy link
Contributor

gr2m commented Aug 25, 2020

What’s missing?

All keys and values are currently added in the order they are documented on https://docs.github.com/en/rest/reference/permissions-required-for-github-apps. We should order all keys and values alphabetically instead.

Why?

We will receive pull requests for every future change in the documentation at https://docs.github.com/en/rest/reference/permissions-required-for-github-apps. The reviews of these changes will be much easier if all keys and values are sorted, and it will prevent false positives in case only the order was changed in the documentation, without an actual change to keys or values

Alternatives you tried

n/a

@gr2m gr2m added Type: Feature New feature or request Status: Up for grabs Issues that are ready to be worked on by anyone labels Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant