Issue 15 add local login page url #17

annemarie35 · 2020-08-04T15:38:19Z

No description provided.

cypress · 2020-08-04T15:39:34Z

Test summary

0 • 6 • 0 • 0

Run details


Project	Moss
Status	Failed
Commit	`1a0e4cd`
Started	Nov 15, 2020 10:37 AM
Ended	Nov 15, 2020 10:38 AM
Duration	01:43 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Electron 78

View run in Cypress Dashboard ➡️

Failures

	create_question_page/create_question_page.spec.js	1
1	Create question page > Renders a form to create the question
	home_page/home_page.spec.js	2
1	Home page > Displays a link to each question page
2	Home page > Displays a link to the create question form
	question_page/question_page.spec.js	3
1	Question page > Renders the question
2	When the user has already voted > Renders the results
3	When the user can vote > Renders the options

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress · 2020-08-04T15:41:27Z

Test summary

0 • 6 • 0 • 0

Run details


Project	Moss
Status	Failed
Commit	`481d8fc` ℹ️
Started	Nov 15, 2020 10:37 AM
Ended	Nov 15, 2020 10:38 AM
Duration	01:35 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Electron 78

View run in Cypress Dashboard ➡️

Failures

	create_question_page/create_question_page.spec.js	1
1	Create question page > Renders a form to create the question
	home_page/home_page.spec.js	2
1	Home page > Displays a link to each question page
2	Home page > Displays a link to the create question form
	question_page/question_page.spec.js	3
1	Question page > Renders the question
2	When the user has already voted > Renders the results
3	When the user can vote > Renders the options

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

.env

src/utils/token.ts

antoinechalifour · 2020-08-06T15:57:40Z

.env.sample

@@ -1 +1,2 @@
-REACT_APP_API_URL='http://localhost:3000/api/v1/'
+REACT_APP_API_URL=


Le API contient le /api/v1 et le base non ? Si oui, on peut mettre ça quelque part ? (Genre readme ou dans le .sample)

Oui en effet, y'a de la duplication.
J'aime bien aussi :

REACT_APP_API_PATH='/api/v1' REACT_APP_BACK_BASE_URL='http://localhost:3000'

Il y aurait juste const apiUrl = process.env.REACT_APP_API_URL!; dans index.tsx à modifier

Pour cette ligne dans package.json par contre, j'ai l'impression qu'il y une coquille dans celui actuel :

"test:serve": "REACT_APP_API_URL=/api/v1 BROWSER=none yarn start",

C'est pas documenté dans le readme, pourquoi est-ce qu'on a cette commande yarn test:serve tu sais

gael-boyenval

chez moi, deploy/netlify plante.
J'arrive sur une page qui semble requetter en boucle.

annemarie35 · 2020-08-26T10:17:26Z

chez moi, deploy/netlify plante.
J'arrive sur une page qui semble requetter en boucle.

Salut @gael-boyenval
J'arrive pas trop à visualiser quel est ton problème.
Est-ce que tu as pu lancer l'app en local avec le back qui tourne ? J'ai eu ce problème de page qui tourne en boucle, cela venant des variables d'environnement qui n'était pas à jour.

ArnoHolo · 2020-11-15T10:23:45Z

.env.sample

@@ -1 +1,2 @@
-REACT_APP_API_URL='http://localhost:3000/api/v1/'
+REACT_APP_API_PATH=
+REACT_APP_BACK_BASE_URL=


Je dirais qu'on peut remplacer BACK par API, pour indiquer que c'est la même application. Ça permet de moins se poser de questions.

ArnoHolo · 2020-11-15T10:24:32Z

src/index.tsx

@@ -14,7 +14,10 @@ import * as serviceWorker from "./serviceWorker";
 import { Theme } from "./ui/Theme/Theme";

 const authToken = getOauthTokenOrRedirect();
-const apiUrl = process.env.REACT_APP_API_URL!;
+
+const apiPath = process.env.REACT_APP_API_PATH!;


Pas sûr que ce soit nécessaire de variabiliser le path de l'API. Ce n'est pas comme si on avait plusieurs versions de l'API pour l'instant.

Suggested change

const apiPath = process.env.REACT_APP_API_PATH!;

const apiPath = "/api/v1";

ArnoHolo · 2020-11-15T10:25:24Z

Hello !

J'ai fait une modif côté back pour que l'API soit sur le port 3001 en local afin qu'il n'y ait pas de redirections en boucle.

J'ai réussi à faire fonctionner cette branche (pas de redirections) côté front en renseignant cela dans .env :

REACT_APP_BACK_BASE_URL=http://localhost:3001
REACT_APP_API_PATH=/api/v1

antoinechalifour suggested changes Aug 5, 2020

View reviewed changes

.env Outdated Show resolved Hide resolved

src/utils/token.ts Outdated Show resolved Hide resolved

src/utils/token.ts Outdated Show resolved Hide resolved

annemarie35 force-pushed the issue-15-add-local-login-page-url branch from 4ddcc91 to 5bb9c2e Compare August 6, 2020 10:08

annemarie35 force-pushed the master branch from b3bf87d to 75caa48 Compare August 6, 2020 10:13

annemarie35 force-pushed the issue-15-add-local-login-page-url branch from 5bb9c2e to 583d9d3 Compare August 6, 2020 11:23

antoinechalifour self-assigned this Aug 6, 2020

antoinechalifour reviewed Aug 6, 2020

View reviewed changes

gael-boyenval suggested changes Aug 21, 2020

View reviewed changes

Anne-Marie added 5 commits August 25, 2020 14:34

use login url for dev environment

4cb63cc

redirect to local login url when not in production env

840e127

use prod or dev env url for login page url

41c0728

rename en variable for better understanding

592356e

refacto

db30b70

annemarie35 force-pushed the issue-15-add-local-login-page-url branch from 5d6461b to db30b70 Compare August 25, 2020 12:38

Some refactoring on env var so we have now url distinct from api path

0a7225e

ArnoHolo reviewed Nov 15, 2020

View reviewed changes

ArnoHolo force-pushed the issue-15-add-local-login-page-url branch from e27e881 to 21a8495 Compare November 15, 2020 10:33

Update README & .env.sample to help developers

1a0e4cd

ArnoHolo force-pushed the issue-15-add-local-login-page-url branch from 21a8495 to 1a0e4cd Compare November 15, 2020 10:34

ArnoHolo linked an issue Nov 15, 2020 that may be closed by this pull request

[contributing] Utiliser Google Auth en local #15

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 15 add local login page url #17

Issue 15 add local login page url #17

annemarie35 commented Aug 4, 2020

cypress bot commented Aug 4, 2020 •

edited

Loading

cypress bot commented Aug 4, 2020 •

edited

Loading

antoinechalifour Aug 6, 2020

annemarie35 Aug 7, 2020

gael-boyenval left a comment

annemarie35 commented Aug 26, 2020

ArnoHolo Nov 15, 2020

ArnoHolo Nov 15, 2020

ArnoHolo commented Nov 15, 2020

		@@ -1 +1,2 @@
		REACT_APP_API_URL='http://localhost:3000/api/v1/'
		REACT_APP_API_URL=

	const apiPath = process.env.REACT_APP_API_PATH!;
	const apiPath = "/api/v1";

Issue 15 add local login page url #17

Are you sure you want to change the base?

Issue 15 add local login page url #17

Conversation

annemarie35 commented Aug 4, 2020

cypress bot commented Aug 4, 2020 • edited Loading

Test summary

Run details

Failures

cypress bot commented Aug 4, 2020 • edited Loading

Test summary

Run details

Failures

antoinechalifour Aug 6, 2020

Choose a reason for hiding this comment

annemarie35 Aug 7, 2020

Choose a reason for hiding this comment

gael-boyenval left a comment

Choose a reason for hiding this comment

annemarie35 commented Aug 26, 2020

ArnoHolo Nov 15, 2020

Choose a reason for hiding this comment

ArnoHolo Nov 15, 2020

Choose a reason for hiding this comment

ArnoHolo commented Nov 15, 2020

cypress bot commented Aug 4, 2020 •

edited

Loading

cypress bot commented Aug 4, 2020 •

edited

Loading