Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table.create can desync the card's index on the table #2144

Open
brine opened this issue Apr 4, 2021 · 1 comment
Open

table.create can desync the card's index on the table #2144

brine opened this issue Apr 4, 2021 · 1 comment

Comments

@brine
Copy link
Contributor

brine commented Apr 4, 2021

to replicate:

  1. put a few cards on the table
  2. run a python function like this:
x = table.create(guid, 0,0,1)
x.sendToBack()

the clienthandler CreateCardAt method will bump the new card's index to the top, overriding the new index applied locally by the sendToBack() API call.

This will end up de-syncing the game state, with the local player seeing the newly created card on the top index while the other players see the card on the bottom index.

@brine
Copy link
Contributor Author

brine commented Apr 4, 2021

the offending code is here:
https://github.com/octgn/OCTGN/blob/master/octgnFX/Octgn.JodsEngine/Networking/ClientHandler.cs#L455

I'm not sure why it does this locally to begin with, maybe we can safely remove that section entirely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant