Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8.0 ignoring root-modules? #177

Open
sellout opened this issue Sep 11, 2024 · 0 comments
Open

2.8.0 ignoring root-modules? #177

sellout opened this issue Sep 11, 2024 · 0 comments

Comments

@sellout
Copy link

sellout commented Sep 11, 2024

I’m on Weeder 2.8.0 (#176, NixOS/nixpkgs@134eef3) and it seems to be ignoring the root-modules setting.

I’m setting up Weeder on an existing project, so I started by adding everything that currently has issues to root-modules:

root-instances = [
    { class = '\.Bifoldable$' },
    { class = '\.Bifunctor$' },
    { class = '\.Bitraversable$' },
    { class = '\.Eq$' },
]
root-modules = [
    '^Unison\.Util\.BiMultimap$',
    '^Unison\.Util\.Logger$',
    '^Unison\.Util\.Relation$',
]
roots = [
    '^Main\.main$',
    '^Paths_.*',
]
type-class-roots = false
unused-types = true

The other fields all work as expected, and the syntax I used for root-modules matches test/Spec/ModuleRoot.toml, so I’m not sure what I’m doing wrong.

Also, I’m curious why the defaults add ^'Paths_.*' to roots instead of to root-modules. I imagine the effect should be the same either way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant