Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Haskell #152

Open
tfausak opened this issue May 1, 2024 · 1 comment
Open

Template Haskell #152

tfausak opened this issue May 1, 2024 · 1 comment

Comments

@tfausak
Copy link
Contributor

tfausak commented May 1, 2024

The README says: https://github.com/ocharles/weeder/blob/66fbba0523bf93abf30323f51670366d577e4f98/README.md#template-haskell

Weeder is currently unable to parse the result of a Template Haskell splice. If some Template Haskell code refers to other source code, this dependency won't be tracked by Weeder, and thus Weeder might end up with false positives.

I couldn't find an open issue for this, so I figured I'd make one.

Obviously this is a known limitation. I'm curious if it's essentially impossible for Weeder to support, or has it just not been implemented yet? I suspect it's more the former, but I can't find any discussion about it.

@ocharles
Copy link
Owner

It's mostly down to what goes in to the HIE AST. I think sometimes for splices it does actually splice in the entire tree, which would mean weeder would be able to look through TH. I think we need some examples of where weeder currently fails, and then we can try and see if it's weeder or GHC that needs to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants