Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format with Fourmolu #123

Open
ocharles opened this issue Jun 23, 2023 · 2 comments · May be fixed by #169
Open

Format with Fourmolu #123

ocharles opened this issue Jun 23, 2023 · 2 comments · May be fixed by #169

Comments

@ocharles
Copy link
Owner

@ryndubei Now that we've got multiple people working on this, I think it might be worth using a formatter, rather than having people faff around with the (somewhat esoteric) formatting I used when I started this project. At CircuitHub, we use the following fourmolu.yaml:

indentation: 2
comma-style: leading
import-export-style: diff-friendly
indent-wheres: true
record-brace-space: false
respectful: true
haddock-style: multi-line
newlines-between-decls: 2
fixities: []
single-constraint-parens: auto

What do you think? Shall we apply this here too? I also suggest we drop the package comments for now, though https://github.com/circuithub/ch-hs-imports does exist to automate this if we want it.

@ryndubei
Copy link
Collaborator

I'm in favour of having a formatter - this config looks good to me. I don't see a reason to remove package comments though, as they work fine with Fourmolu and I imagine they would be helpful in cases of switching out some package for another.

@ocharles
Copy link
Owner Author

Cool, let's add fourmolu and keep the comments then

ocharles added a commit that referenced this issue Jun 10, 2024
@ocharles ocharles linked a pull request Jun 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants