Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lets-encrypt-update (probably) shouldn't die when a certificate issuance fails #1265

Open
ethanwu10 opened this issue Feb 23, 2022 · 1 comment
Open

lets-encrypt-update (probably) shouldn't die when a certificate issuance fails #1265

ethanwu10 opened this issue Feb 23, 2022 · 1 comment

Comments

@ethanwu10
Copy link
Member

Right now, if issuing a single certificate fails, lets-encrypt-update will die with an assertion failure

puppet/modules/ocf_www/files/lets-encrypt-update

Line 129 in f54d123

assert ret == 0, 'ocf-lets-encrypt returned {}'.format(ret)

We should probably log the error and keep going, so we keep updating the remaining certificates (assuming the failure was specific to a host)—also ensuring that if any errors happen, we exit nonzero.
@singingtelegram
Copy link
Member

it's failing !!1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@singingtelegram @ethanwu10