Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPSS] Add setters & input validation (merge from PR #1281) #1346

Closed
trentmc opened this issue Jul 5, 2024 · 0 comments · Fixed by #1347
Closed

[PPSS] Add setters & input validation (merge from PR #1281) #1346

trentmc opened this issue Jul 5, 2024 · 0 comments · Fixed by #1347
Assignees
@trentmc
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Jul 5, 2024

Background / motivation

PR #1281 is a huge PR towards issue #1281. Some of it I may never merge. But some of it is immediately good to have in main, to minimize the PR size.

I have many good changes to pdr_backend/ppss/ that could move over. And related unit tests.

  • validating inputs
  • setters
  • expanded unit tests

TODO

  • Move ppss changes to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentmc trentmc

Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1346: [PPSS] Add setters & input validation oceanprotocol/pdr-backend
1 participant
@trentmc