Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plots] Write basic end-to-end tests for sim plots & arima plots #1209

Closed
1 of 2 tasks
trentmc opened this issue Jun 13, 2024 · 0 comments · Fixed by #1235
Closed
1 of 2 tasks

[Plots] Write basic end-to-end tests for sim plots & arima plots #1209

trentmc opened this issue Jun 13, 2024 · 0 comments · Fixed by #1235
Assignees
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Jun 13, 2024

Background / motivation

Sim engine plots have now hit a relatively stable macro-state: using plotly, etc.

But we don't have tests for them at the macro level yet.

We do have some macro-level tests for arima plots: in statutil/test/test_arima_dash_plots.py and test_dash_plots_utils.py. However they're not enough either. For example, #1206 was a small bug, yet it prevented arima plots from launching. The existing tests didn't catch it.

TODOs

  • Write basic end-to-end tests for sim engine plots (pdr sim_plots), such that after a short sim run, can they plot everything without something crashing. To keep runtime fast, this could be done as part of test_sim_engine.py -> done in Add sim_plots testing with Dash testing (Dash duo) #1228
  • Write basic end-to-end tests for arima plots (pdr arima_plots). Test it on the data thattest_seasonal.py::_get_data() uses

Related issues

A good follow-up issue to this one is: #1208 "In sim and pdr bot tests, need to test both classifier and regressor ai models"

@trentmc trentmc added the Type: Enhancement New feature or request label Jun 13, 2024
@trentmc trentmc changed the title [Sim plots] Write basic tests for sim engine plots [Sim plots] Write basic tests for sim plots Jun 13, 2024
@trentmc trentmc changed the title [Sim plots] Write basic tests for sim plots [Plots] Write basic end-to-end tests for sim plots & arima plots Jun 13, 2024
@calina-c calina-c self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants