Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lake][Test] Re-enable subscription table + create fixture + test data #1085

Closed
4 tasks
idiom-bytes opened this issue May 23, 2024 · 1 comment
Closed
4 tasks

Comments

@idiom-bytes
Copy link
Member

idiom-bytes commented May 23, 2024

Describe the bug
While I was debugging the data pipeline, I noticed subscription testing was hooked up but there was no data provided. This means that the testing fixture was half-implemented. For now, I have disabled subscription as part of "reducing the scope -> getting to stable -> expanding scope".

As part of stabilizing the build and keeping it stable, we need to make sure the fixture and tests are working and covering subscription functionality as expected.

Please address subscriptions properly after getting duckdb build sorted out.

image

DoD:

  • Following along with the rest of ETL test data - Create sample data for multiple days of subscriptions..
  • Hook up sample data and table to fixture
  • Update fixture tests and verifications
  • Make sure that gql, etl, and other subscription tests are using fixtures

Issues referencing this one

@idiom-bytes idiom-bytes changed the title [Lake][Test] Hookup subscription sample data into fixture + update tests [Lake][Test] Implement subscription fixture + test data May 23, 2024
@idiom-bytes idiom-bytes changed the title [Lake][Test] Implement subscription fixture + test data [Lake][Test] Re-enable subscription table + create fixture + test data May 28, 2024
@idiom-bytes
Copy link
Member Author

Tracking remaining issues in #1299 closing this for now until we focus on solving this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant