-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCHISM integration #2
Comments
Thanks @uturuncoglu . For schism I also tag @josephzhang8 . |
Maybe I could go with |
ike_shinnecock.sch seems standalone test. So maybe it is good to start with it without worrying data atmosphere etc. Let me start with it and maybe I could define it as RT under UFS. |
@platipodium @saeed-moghimi-noaa @pvelissariou1 @josephzhang8 |
Thanks @uturuncoglu ... quite a beast to download :=). On my M1 the command should be |
New issue #3 The CMAKE_FIND package does not locate my installed PIO, I'll make a new issue |
@josephzhang8 The exiting CoastalApp was using OLDIO ( |
@josephzhang8 I tried to compile without OLDIO but I am getting following error when I run the model,
So, maybe the configuration needs to be adjusted to run in this case. Let me know if I need to change any option in the |
@josephzhang8 Okay. I'll check the documentation. Thanks for your help. |
Hi All, I added new RT under tests/rt_coastal.conf (in the same branch) ./rt.sh -l rt_coastal.conf -k -n coastal_ike_shinnecock_sch It is running in my side (still uses old I/O, once I test new one I'll fix the configuration). To run ufs_coastal related RT, you need to copy input directories and make minor change in the rt.sh to point your new input directory. Let me know if you need to access them. They are on Cheyenne. What is next? I am plaining to continue to work and run one coupled schism configuration. It seems ike_shinnecock.atm2sch uses data atmosphere. So, running first with NUOPC connector and then with CMEPS would be good to see if we have issue with CMPES like we had in ADCIRC component. It would be also nice to sync with UFS Weather Model since lots of development done after we fork it. So, this would be a good test for syncing ufs-coastal. @pvelissariou1 If you don't mind, could you send me CFS data for 2008-08-23? I am not sure this configuration also covers the same region like |
@uturuncoglu @pvelissariou1 @josephzhang8 @platipodium Very good progress indeed. I agree with staying with schism to include more of the tests. For the pull request I have no idea when would be the best time. I feel like it make sense if we start a regular weekly tag-up (perhaps just 30 min) for now only with schism developers. We are still waiting to hear back from adcirc folks. FVCOM also just finished their tests for nems-fvcom and nems-ww3-fvcom. They are also actively working with us right now. As another avenue to take if adcirc folks stayed unresponsive. |
Saeed, Ufuk
Joannes just scheduled a meeting next Tuesday to discuss the
CoastalApp/ADCIRC CMEPS issues.
He used one of their regular meetings where all parties are participating.
Takis
Panagiotis Velissariou, Ph.D., P.E.
UCAR Scientist
National Ocean and Atmospheric Administration
National Ocean Service
Office of Coast Survey CSDL/CMMB
Physical Scientist - Project Lead
cell: (205) 227-9141
email: ***@***.***
…On Fri, Mar 31, 2023 at 12:58 PM Saeed Moghimi ***@***.***> wrote:
@uturuncoglu <https://github.com/uturuncoglu> @pvelissariou1
<https://github.com/pvelissariou1> @josephzhang8
<https://github.com/josephzhang8> @platipodium
<https://github.com/platipodium>
Very good progress indeed. I agree with staying with schism to include
more of the tests. For the pull request I have no idea when would be the
best time. I feel like it make sense if we start a regular weekly tag-up
(perhaps just 30 min) for now only with schism developers. We are still
waiting to hear back from adcirc folks. FVCOM also just finished their
tests for nems-fvcom and nems-ww3-fvcom. They are also actively working
with us right now. As another avenue to take if adcirc folks stayed
unresponsive.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APC7TP5YXCEECSFDHJVIZNTW64LKJANCNFSM6AAAAAAWNY76MU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@josephzhang8 let me test in my side. If there is some issue with .gitmodules file that could create issue. |
@saeed-moghimi-noaa Just to clarify. I will not have PR in UFS Weather Model side. I am just planing to bring their updates to our fork (and to branch). That is all. So we could keep up-to-date along with the development in UFS Weather Model side. I think we decided not to push anything to UFS Weather Model authoritative repository yet in our last call. |
@uturuncoglu Thanks for the clarification. Understood. |
@josephzhang8 Following command works for me (I named the directory as TEST). git clone --recursive -b feature/coastal_app https://github.com/oceanmodeling/ufs-coastal.git TEST BTW, since ADCIRC is private repository, they need to add you (maybe you are already in that group) and enter password when git asks. |
@josephzhang8 Yes that is the plan but we will keep it up-to-date with authoritative repository. I could also make this branch default so you don't need to specify branch in the clone but we could decide it later. I am plaining to keep develop up-to-date with authoritative repository. Anyway, we could discuss these details in the next call. |
@josephzhang8 @platipodium I set
but still getting same error. I think this is because of not building I think we make this as an option in ESMF config file (under |
@josephzhang8 Sure. That sounds fine. |
Go ahead with making that an option. We did not so far because in principle none of the models should do I/O, but rather a dedicated I/O server.... |
@josephzhang8 There are some information in the following link to port UFS coastal, https://oceanmodeling.github.io/ufs-coastal-app/versions/main/html/porting.html#docker-container and more information about porting to another platform is very similar to the ufs-weather-model, https://spack-stack.readthedocs.io/en/latest/ Please refer to this both document and try to port ufs-coastal. If you could able to take notes and share your experiences, we could add them to the app level documentation and it would be helpful for other users. |
Thanks @uturuncoglu . Since our college system is shared I'll need to ask admin to install some packages. Meanwhile I was able to compile on hercules but could u tell me the binary location/name? Thx. |
@josephzhang8 I am compiling on hercules and orion right now. On hercules it fails to compile SCHISM due to the missing python executable (usually a link to python3). Changed that in the Cmake file for schism and it compiled. Anyway the executable is at: build_fv3_coastal/ufs_model and the command: nm -a ufs_model | grep -i schism |
@uturuncoglu spack-python/3.9.14 doe not provide the link python->python3 as it points to system's installed python. Need to fix this. |
Thx @pvelissariou1 . It's strange b/c I did not see any errors when building on hercules but I did a global search and failed to find ufs_model |
@pvelissariou1 we need to open issue in spack-stack if it is not related with the component. I know 1.5.1 will be available soon and maybe they fixed before it. Btw, the UFS moved to 1.5.0 recently. So, maybe it is fixed already. We need to sync UFS-Coastal to get those changes. |
@pvelissariou1 I sync the model with upstream. Testing now. I'll update you soon. I'll also test on hercules If I could to see the issue. BTW, which case are you trying to install. |
@uturuncoglu I just tried to compile using: The python command is hardcoded into SCHISM's CMake file |
Maybe my python env is set up differently on hercules, and I did not encounter any issue there - or maybe that's why I did not see the binary? |
@pvelissariou1 I tested ROMS, SCHISM and WW3 tests and fixed them (there was some changes in the RT framework and our tests need to be adjusted). They are running without any issue. I'll also fix ADCIRC and FVCOM tests. The synced model has spack stack 1.5. I'll test the updated model on Hera to see I could reproduce the Python issue. If I could, I will fix and let you know. |
@pvelissariou1 I could compile SCHISM datm configuarion on Hercules without any issue after syncing ufs-coastal with automative repository (not using spack-stack 1.5). Please try in your end and let me know if you have any issue. |
@uturuncoglu Thank you so much Ufuk. Upon my return I will check UFS-Coastal on the different platforms and finalize the RTs for SCHISM/PAHM/WW3. I thought we had a good meeting last Friday with Joseph and Carsten. Let's keep the plan we discussed about SCHISM in UFS-Coastal. We also need to start thinking about 3D support for SCHISM in UFS-Coastal (SCHISM+WW3, CICE and sediments/water quality). Again, thank you for all your efforts. |
@pvelissariou1 Sure. No worries. It is not urgent. Best, |
Hi Takis, I have following your steps and compile UFS-coastal for SCHISIM with internal WWM on Hera, it gives me the following mistakes for
for It gives :
And the line 99 looks like:
My work folder is located at /scratch2/STI/coastal/Yunfang.Sun/run_schism/schism_wwm/ufs-coastal-coastal_app/ on Hera. Thank you! |
@yunfangsun Lets talk about this in the meeting. I'll try it again on hera |
Hi, I am doing schism RT on frontera with the following command. It's a bit odd the script won't select the specified test. |
@danishyo This is known as issue in UFS weather model and once we sync the UFS coastal we also inherited the bug. It will be fixed soon. In the meantime time you could edit conf file and just keep the test that you want to run and run rt.sh without -n option. I hope it helps |
Thanks, @uturuncoglu ! |
Hi I try to run RT coastal_ike_shinnecock_atm2sch2ww3 with latest code on Frontera without a success. I also notice when I do RT coastal_ike_shinnecock_atm2sch on Hercules, DATM_ATMMESH_input_data is missing under input-data-20221101. |
@danishyo Let me try in my end. As I know it was working fine but it is always nice to double check. If I remember correctly, we might need to run ww3_grid again to recreate some of the wave files wince new version of WW3 was not happy with old version of the code. Maybe I could sync the input directory again to solve the issue. I'll update you. |
Thanks @uturuncoglu |
@danishyo Okay. I fixed the files. Now, it is running in my end. The baseline check is failing but I think we need to create baseline again since there was some change in the SCHSIM side. I'll do that too. But, this will not prevent you to run the case. |
Thanks @uturuncoglu |
@platipodium @saeed-moghimi-noaa @pvelissariou1
I am creating this issue to communicate the SCHISM related developments. I am planing to do the same for each component. So, we could focus specific component in each issue. Anyway here is my update about the ongoing development regarding to SCHISM:
feature/coastal_app
branch.SCHISM/src/CMakeLists.txt
file and add new option likeBLD_STANDALONE
. This isON
by default and will not change anything interns of existing functionality but when I build SCHISM under UFS I am setting it toOFF
since I don't want to build Driver and finding libraries (they are provided by UFS). I tried to use the exiting build system as much as possible to create SCHISM-Interface under UFS but we could change the design in the later stage of the project. You could see the changes in the following link,https://github.com/schism-dev/schism/compare/master...uturuncoglu:schism:feature/coastal_app?expand=1
*shinnecock*
but I could not use them without having ESMF Mesh file for the atmospheric forcing and also 2d forcing fields (CDEPS requires those). As a workaround, I could go with the CFS data that are provided by @pvelissariou1 for theflorence_hsofs.atm2adc
and used by new CDEPS mode (ATMMESH
) but I am not sure that will work with the SCHISM configuration or not. So, I need some guidance to create test case to test SCHISM build.The text was updated successfully, but these errors were encountered: