-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DataInitialize #3
Comments
@uturuncoglu So the ADCIRC NUOPC cap is not working as expected. How long to fix this? |
@pvelissariou1 The cap is working since we are not testing restart capability of the component at this point. I think I could create an issue like SCHSIM in the reproducibility (magically we have no that issue now) since ocean mask is not available in the initialization phase of the mediator. So, this is not an urgent fix but must be fixed. It is not a too much work but since these caps are not developed by following the exiting convention etc. It could take little bit longer because I also split the advance call and create others calls just for dedicated to update import and export states. |
@uturuncoglu Ok, thanks. Please create an issue so we can keep track. |
@pvelissariou1 Sure. ROMS has no this issue since it is developed by testing retorts etc. and has robust testing mechanism. BTW, I have already implemented for SCHSIM. It is in a fork at this point and created a draft PR. |
@pvelissariou1 @yunfangsun @janahaddad @saeed-moghimi-noaa The
NUOPC_Label_DataInitialize
needs to be specialized for the ADCIRC to exports component fields during initialization or restart. This is not done in the current version of the NUOPC cap and might be required for the reproducibility. This requires extensive restructuring cap.The text was updated successfully, but these errors were encountered: