Laser Line Calibration #111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed findLaserInImage to return weighted average mean of all points detected on the laser line (should be relatively constant)
Addition of fit_and_save for a line not a plane
added fit_and_save under Class:Laser
added fi andsave line to class laser calibrator
added notes to Class: Plane to help understand code and adapt to Class: Line
Class:Line, adapted from coeff and distance functions
reverted findLaserInImage
changed findLaserInImage to return the coordinate for the centre pixel
made initial changes to fit_and_save_line to actually fit a line and not a plane
added new function of plot_pointcloud _and_lines
Completed plot_pointcloud_and_Lines
included import of Class Lines and plot_points_and_lines
updated cal to use fit_and_save_line
fixed ray intersection for class line added in missing end bracket
Readd the import for Plane
Changed remaining parts of fit_and_save_line to create line and not plane. Also updated findLaserInImage to accept middle column as the only pixel line to check.
Ensured correct variables are being called eg. normal is now direction
Removed plot_pointcloud_and_planes. REINCLUDE!!!! Updated some parts to accept line not plane
updated run_ransac to use estimate function instead of fit_plane function
updated to understand code
added notes to help understand function
added notes to augment, fir_plane and is_inlier for understanding
added fit_line
added is_inlier_line (code reused from plane_fitting.py - Class: Line - distance
added line_fitting_ransac function (not complete)
finished line_fitting_ransac, also added and defined plot_line
changed to line fitting ransac for the if clause, for future update when meshing both line and plane lasers, need to add an if clause for if laser == line or if laser == plane
highlighted problem code line for 3d plots, use plotly, has not been changed as it is currently not in use. But it may work from the console and not other python softwares.
readded import for class plane from plane fitting
created line_through_two_points using same notation for other line definitions
readded plot_pointcloud_and_planes after removal corrected the plotting of plot_pointcloud_and_lines
hashed out cone_fitting as it is unused but still causes error in terminal window
rewrote and corrected sections of ransac for line fitting
corrected parts of functions for lines as well as keeping with consistent notation
corrected function plot pointcloud and lines so that the output html file has a line instead of being left blank
corrected changes as well as labeling others. Main change is use of ransac to return line function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.