lint: add W74 to detect 'pin-depends' packages that are not present in 'depends' nor in 'depopts' #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 'depends' nor in 'depopts'
kit-ty-kate
previously approved these changes
Nov 28, 2024
kit-ty-kate
reviewed
Nov 28, 2024
| |> List.map OpamPackage.Name.to_string | ||
| in | ||
| cond 74 `Warning | ||
| "Field 'pin-depends' contains packages that are not in 'depends' nor in \ |
There was a problem hiding this comment.
Suggested change
| "Field 'pin-depends' contains packages that are not in 'depends' nor in \ | |
| "Field 'pin-depends' contains packages that are neither in 'depends' nor in \ |
kit-ty-kate
reviewed
Nov 28, 2024
| @@ -60,6 +60,7 @@ users) | |||
| ## Source | |||
|
|
|||
| ## Lint | |||
| * [NEW] Add W74 to detect `pin-depends` packages that are not present in `depends` nor `depopts` field [#6317 @rjbou - fix #5795] | |||
There was a problem hiding this comment.
Suggested change
| * [NEW] Add W74 to detect `pin-depends` packages that are not present in `depends` nor `depopts` field [#6317 @rjbou - fix #5795] | |
| * [NEW] Add W74 to detect `pin-depends` packages that are neither present in the `depends` nor `depopts` field [#6317 @rjbou - fix #5795] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5795
This lint doesn't detect when the versions mismatch.