Run shellcheck on shell/install.sh and make it pass #6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice to see this going forward! |
rjbou
reviewed
Nov 28, 2024
kit-ty-kate
force-pushed
the
shell-check-install
branch
from
41cf7ba
to
de764d4
Compare
Co-authored-by: Ambre Austen Suhamy <[email protected]>
kit-ty-kate
force-pushed
the
shell-check-install
branch
from
de764d4
to
1e2f399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial subset of #5778.
This PR is meant as a way to more easily kickstart the use of shellcheck to lint checkout shell scripts.
Details of reason behind the shell changes:
$()vs backtickslocal$@in stringsreadwithout-rwill interpret backslashesprintfcould contain%which could make the command failThis PR also make sure the script keeps passing
shellcheckby adding it to our CI.