Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depext: Add Altlinux family support #6207

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

RiderALT
Copy link
Contributor

using rpm for a package manager and apt-rpm (fork of the apt fron debian wuth RPM support) for the repository manager.

Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

This change looks reasonable modulo the one suggestion.
If you have some spare time, would you be able to add altlinux to our testsuite? (see the files .github/workflows/depexts.yml and .github/scripts/depexts/generate-actions.sh) It should just be a case of either merging the debian and altlinux case or copy-pasting. Altlinux is available as alt on Docker Hub.

If you don't have time we'll do it at some point in the future

src/state/opamSysInteract.ml Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Sep 25, 2024
using rpm for a package manager and apt-rpm (fork of the apt fron debian wuth RPM support) for the repository
manager.
@rjbou
Copy link
Collaborator

rjbou commented Oct 29, 2024

It is not possible ftm to add a depext test as it there is no conf package that have Altlinux support on main opam repository. A PR is added for when it will be the case #6277

Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit f898d21 into ocaml:master Oct 29, 2024
52 checks passed
@RiderALT
Copy link
Contributor Author

Thank you very much for the merging, unfortunately I could not get to the Docker and make tests for altlinux, but I remember about this task.

@rjbou
Copy link
Collaborator

rjbou commented Oct 30, 2024

No worries, the docker test PR is already opened, see #6207 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants