source: add --no-checksums & --require-checksums flags
#5563
Conversation
rjbou
added
the
PR: QUEUED
rjbou
added
PR: WAITING FOR REVIEW
and removed
PR: QUEUED
src/client/opamCommands.ml
Outdated
| mk_flag ~cli (cli_from cli2_2) ["require-checksums"] | ||
| "Enforce checksum verification befor downloading sources.\ | ||
| This is equivalent to setting $(b,\\$OPAMREQUIRECHECKSUMS) to \"true\"." | ||
| in |
There was a problem hiding this comment.
might be worth sharing the flags definitions with the ones used in OpamArg.build_options ? (maybe that was too tedious to be worth it, in that case it's alright)
There was a problem hiding this comment.
|
Appreciated, and this looks great to me. As @AltGr mentioned, it may be useful to share some code. Thanks a lot. |
…he counterpart of that is that we loose the fact that the newly effective options (in opam source for ex) are not flaggued as new in cli 2.2
…ption. The counterpart of that is that we loose the fact that the newly effective options (in opam source for ex) are not flaggued as new in cli 2.2" This reverts commit a2e7b21ccaad48ca11432e9fbd0a7a2c90377aee.
rjbou
force-pushed
the
source-install
branch
from
ef3b1e2
to
a5171aa
Compare
There was a problem hiding this comment.
I don't understand this feature request. What does this bring in terms of change for users?
I understand --require-checksums, although i feel like this would have more usability as a global opam option.
But --no-checksums i really don't understand. If the goal is to allow packages without a checksum, then why not simply add a --allow-no-checksums argument instead of ignoring the checksum altogether?
I'm also wondering what how opam source is special compared to the other commands that might fetch packages.
| let no_checksums = no_checksums cli (cli_from cli2_2) in | ||
| let req_checksums = require_checksums cli (cli_from cli2_2) in |
There was a problem hiding this comment.
| let no_checksums = no_checksums cli (cli_from cli2_2) in | |
| let req_checksums = require_checksums cli (cli_from cli2_2) in | |
| let no_checksums = no_checksums cli (cli_from cli2_4) in | |
| let req_checksums = require_checksums cli (cli_from cli2_4) in |
/cc @hannesm @reynir