Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the "jobs" config variable when upgrading from opam 2.0 #5284

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Reset the "jobs" config variable when upgrading from opam 2.0 #5284

merged 1 commit into from
Oct 31, 2022

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate marked this pull request as ready for review September 14, 2022 19:31
@rjbou
Copy link
Collaborator

rjbou commented Sep 15, 2022

Agree on the idea, but what if user set its jobs variable to that value? Should we add a warning to inform that we are removing that value?

@kit-ty-kate
Copy link
Member Author

Agree on the idea, but what if user set its jobs variable to that value? Should we add a warning to inform that we are removing that value?

Indeed that's a good idea. I've done that and fixed the rest of the issues. It should be good to be reviewed once again.

@rjbou rjbou merged commit 8c58139 into ocaml:master Oct 31, 2022
@kit-ty-kate kit-ty-kate deleted the fix-45 branch October 31, 2022 13:08
@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha milestone Oct 31, 2022
@rjbou rjbou mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou left review comments

@AltGr AltGr AltGr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@kit-ty-kate @rjbou @AltGr