-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep writes within IOV_MAX #633
Labels
bug
Something isn't working
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Calling
Flow.write
with more thanIOV_MAX
buffers results inEINVAL
. This can happen when e.g. usingBuf_write
to write a lot of data without flushing.Reported by @Cjen1 (see https://github.com/Cjen1/prototyping-testing/tree/master/eio-pipe).
Implementations of
Flow.write
with such limits should just truncate the list of buffers. PossiblyBuf_write
should also know the limit and flush before sending so many (or just use a low enough limit that it work on all platforms).On Linux, ocaml-multicore/ocaml-uring#76 can be used to get the limit.
The text was updated successfully, but these errors were encountered: