Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "available" metadata on eio_windows #619

Open
talex5 opened this issue Sep 22, 2023 · 2 comments
Open

Restore "available" metadata on eio_windows #619

talex5 opened this issue Sep 22, 2023 · 2 comments
Labels

Comments

@talex5
Copy link
Collaborator

talex5 commented Sep 22, 2023

ocaml-ci currently only tests Eio on Linux because uring isn't installable on macos. And if eio_windows correctly stated that it only works on Windows, we wouldn't be able to test anywhere at all!

ocurrent/solver-service#72 will fix that, by testing only the compatible packages on each platform. Once it's in, uncomment the "#available" line in eio_windows.opam.template so that package has correct metadata (and doesn't need to be corrected manually on each release).

@patricoferris
Copy link
Collaborator

Looks like that PR is in @talex5 -- are we good to uncomment that line ? :))

@talex5
Copy link
Collaborator Author

talex5 commented Oct 2, 2024

Ah, I think we need a slight update to the CI too. If a package can't be tested on any platform then it fails the analysis stage. Since ocaml-ci doesn't test on Windows, I think it will complain that eio_windows can't be tested. We need to relax that rule in ocaml-ci first.

@talex5 talex5 added the windows label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants