Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency graphs in sequential/parallel web pages #114

Closed
shakthimaan opened this issue Nov 26, 2022 · 5 comments
Closed

Add latency graphs in sequential/parallel web pages #114

shakthimaan opened this issue Nov 26, 2022 · 5 comments
Assignees

Comments

@shakthimaan
Copy link
Contributor

The instrumented pausetimes which use eventring have been updated to Sandmark at ocaml-bench/sandmark#358. The sequential and parallel web pages should now include the latency, max latency and 99.9th percentile graphs available in the following notebooks:

https://github.com/ocaml-bench/sandmark/blob/429f52f7b0ea9dbe760b3e249a17cd0b7b629e95/notebooks/sequential/sequential.ipynb

https://github.com/ocaml-bench/sandmark/blob/429f52f7b0ea9dbe760b3e249a17cd0b7b629e95/notebooks/parallel/parallel.ipynb

@Firobe
Copy link

Firobe commented Nov 29, 2022

Can I close this in favor of ocaml-bench/sandmark#420?

@punchagan
Copy link
Contributor

I think we also want to show them in the sandmark-nightly UI, which unfortunately doesn't re-use the code from the notebooks.

@shakthimaan
Copy link
Contributor Author

Can I close this in favor of ocaml-bench/sandmark#420?

We will need both. The Sandmark notebooks are used for prototyping and also by compiler developers if they would like to test the output locally on their machines. If there are any specific improvements, we also make it available in the sandmark-nightly runs.

@Firobe
Copy link

Firobe commented Nov 30, 2022

Understood! I hadn't yet realized the code for both tasks was not shared.

@Firobe Firobe self-assigned this Dec 1, 2022
@punchagan
Copy link
Contributor

Closed in #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants