Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatMap.max_binding BatMap.empty raises Invalid_argument instead of Not_found #870

Open
bnguyenvanyen opened this issue Jul 13, 2018 · 3 comments

Comments

@bnguyenvanyen
Copy link

Whereas min_binding, pop_min_binding, pop_max_binding and (all ?) others raise Not_found.
It would make more sense if it was Not_found also (but it somewhat breaks backward compatibility).

Thank you for batteries

@UnixJunkie
Copy link
Member

This is inconsistent with the stdlib, so I think it should be fixed.

@fccm
Copy link
Member

fccm commented Nov 11, 2021

While doing the PR I also noticed that the Stdlib also provide exceptionless Map.min_binding_opt and Map.max_binding_opt that return an option.
Should we also add these?

@UnixJunkie
Copy link
Member

please open a separate issue.
Note that the priority should be to do the release; such things could go into the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants