Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise Token Identity run_and_compute() method #54

Open
shaheenahmedc opened this issue Apr 26, 2024 · 0 comments
Open

Generalise Token Identity run_and_compute() method #54

shaheenahmedc opened this issue Apr 26, 2024 · 0 comments

Comments

@shaheenahmedc
Copy link
Collaborator

The TokenIdentity class in obvs/lenses.py currently has a run_and_compute() method, which uses batched versions of surprisal and precision. It also calculates these metrics alongside running the patchscope, saving GPU memory.

The PatchscopeLogitLens and ClassicLogitLens don't use such a method, but would benefit from it.

Can we generalise this run_and_compute() method to work for any lens? Or should it work for any patchscope?

This arose from #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant