Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchscopeLogitLens & ClassicLogitLens run method have different arguments #47

Open
llinauer opened this issue Apr 22, 2024 · 0 comments

Comments

@llinauer
Copy link
Collaborator

Since we want to follow the scikit-learn .fit type of execution for all our .run methods, the PatchscopeLogitLens and the ClassicLogitLens .run methods should take the same arguments.
This should be doable.

The SourceContext position attribute can be a sequence of integers. So, we can process more than one positions in one Patchscope "patch". This means, we can pass a sequence of integers to the PatchscopeLogitLens .run method as well.

We then simply need to change the ClassicLogitLens .run method to take the same arguments and adapt all scripts that use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant