Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onload in sample plugin is not compatible with type definition #117

Open
TfTHacker opened this issue Sep 15, 2024 · 1 comment
Open

onload in sample plugin is not compatible with type definition #117

TfTHacker opened this issue Sep 15, 2024 · 1 comment

Comments

@TfTHacker
Copy link
Contributor

First... I am not TypeScript expert. However, it seems to me the sample plugin code is using:

async onload() {

async onload() {

Howerver the type definition is:

onload(): void;

https://github.com/obsidianmd/obsidian-api/blob/e523ed9c94480c8b5129d607b8ad5e4456cfcd3a/obsidian.d.ts#L777

This can generate errors when eslint is used.

Tnx!

@obsidianmd obsidianmd deleted a comment from 3C0D Oct 23, 2024
@obsidianmd obsidianmd deleted a comment from 3C0D Oct 23, 2024
@liamcain
Copy link

Thanks! The type definitions have been updated so that Plugin.onload is now async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants