Toggling a task with done date overwrites the done date when toggling task via clicking on the checkbox

[ilandikov]

Please check that this issue hasn't been reported before.

• I searched previous Bug Reports didn't find any similar reports.

Steps to reproduce

• let's assume that today is 2024 Oct 20th.
• set global filter to #task
• add the following task line: - [ ] #task with done date in the past, but not completed yet ✅ 1970-01-01
• in reading mode or in dynamic mode click on the task's checkbox to complete it

Expected Behavior

• the task will be completed keeping the done date that was in the line before completion

Current behaviour

• the done date is overwritten with today's date

Which Operating Systems are you using?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

Obsidian Version

1.7.4

Tasks Plugin Version

7.11.1+ (d732bbb)

Checks

• I have tried it with all other plugins disabled and the error still occurs

Possible solution

This happens in case when in the edit task modal I input the done date to a date previous that today and forget to change the status to done.

[claremacrae]

I think we need start being smarter about all these consistency checks.

• So far we've implemented a bunch of consistency checks in the Edit Task modal.
• This introduces the need for consistency checks in the toggle-checkbox code.
• And later there will likely be reports of inconsistencies in the toggle command...
• And in the documentation, we have a page on Find tasks with potentially invalid data - meaning that users need to set up their own searches for invalid data - and remember to update their searches every time we add support for a new field.
• Also, there is currently no way to report to users, when parsing all tasks in the vault, that they have any task lines with problems, such as tasks with invalid dates.

I think it's time to consider stopping fixing these piecemeal, and instead introducing an abstraction for errors and warnings on task date data - and then making the commands, modal and similar, use that abstraction.

So that when we add a new check, all the locations benefit from this simultaneously.

[ilandikov]

I think this is a great idea!