Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format tip pair as a single value when the two values are equal? #2135

Open
Fil opened this issue Aug 15, 2024 · 1 comment
Open

Format tip pair as a single value when the two values are equal? #2135

Fil opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Fil
Copy link
Contributor

Fil commented Aug 15, 2024

By default when formatting pairs (y1, y2), we display ${format(a)}—${format(b)}. It does not feel terribly useful to repeat the value when a and b end up being formatted identically.

If for example you're showing a tip on an interval that is [3.1—3.2] with an integer format, showing "3" (read as "somewhere around 3 something") is as informative and slightly better than "3—3" ("between 3 something and 3 something").

This does not happen often, since hopefully the format discriminates between values, but when it happens we would be as happy with showing ${format(a)} alone.

I tried to thing of a case where on the opposite, one might want to show a repetition; for example on a calendar where you want to show an interval that goes "from Sunday to Sunday", as "Sun—Sun". In that case, you would have to create a specific channel since the automatic tip format would now show "Sun" only.

This enhancement would incidentally help with the waffle tips (#2132), but is not necessary for them, and should be discussed on its own merits.

(Note: does not apply when the value is the difference — i.e. hint: {length: true}).

@Fil Fil added the enhancement New feature or request label Aug 15, 2024
@Fil Fil self-assigned this Aug 15, 2024
@Fil Fil changed the title Format tip pair as a single value when the two values are equal Format tip pair as a single value when the two values are equal? Aug 15, 2024
@Fil
Copy link
Contributor Author

Fil commented Aug 22, 2024

A case found in the wild: the binning of integers between 0 and 7, that results (by default) in small bins such as [4 — 4.5]. If the format was showing only the integer part (as suggested in #1268), this PR would automagically solve this case.
integer tip

(However in this case, we'd also want the bin labels to be "4" and not "4 inclusive to 5 exclusive".)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant