From 5abb422bb8cf17f5b54f404963eb6dd30901da96 Mon Sep 17 00:00:00 2001
From: Ryan Hopper-Lowe <ryan@acorn.io>
Date: Fri, 20 Dec 2024 12:47:51 -0600
Subject: [PATCH] fix: additionally start knowledge polling when source is
 pending

---
 ui/admin/app/components/knowledge/AddSourceModal.tsx  |  5 ++++-
 ui/admin/app/components/knowledge/CronDialog.tsx      |  2 +-
 .../components/knowledge/KnowledgeSourceDetail.tsx    | 11 ++++++++++-
 .../app/hooks/knowledge/useKnowledgeSourceFiles.ts    |  5 ++++-
 4 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/ui/admin/app/components/knowledge/AddSourceModal.tsx b/ui/admin/app/components/knowledge/AddSourceModal.tsx
index ede13a74b..3551a1202 100644
--- a/ui/admin/app/components/knowledge/AddSourceModal.tsx
+++ b/ui/admin/app/components/knowledge/AddSourceModal.tsx
@@ -58,7 +58,10 @@ export const AddSourceModal: FC<AddSourceModalProps> = ({
 
     return (
         <Dialog open={isOpen} onOpenChange={onOpenChange}>
-            <DialogContent aria-describedby={undefined} className="max-w-2xl">
+            <DialogContent
+                aria-describedby="add-source-modal"
+                className="max-w-2xl"
+            >
                 <DialogTitle className="flex flex-row items-center text-xl font-semibold mb-4 justify-between">
                     <div className="flex flex-row items-center">
                         <KnowledgeSourceAvatar
diff --git a/ui/admin/app/components/knowledge/CronDialog.tsx b/ui/admin/app/components/knowledge/CronDialog.tsx
index 5c3350b1e..a515e8192 100644
--- a/ui/admin/app/components/knowledge/CronDialog.tsx
+++ b/ui/admin/app/components/knowledge/CronDialog.tsx
@@ -24,7 +24,7 @@ const CronDialog: FC<CronDialogProps> = ({
 
     return (
         <Dialog open={isOpen} onOpenChange={onOpenChange}>
-            <DialogContent aria-describedby={undefined} className="max-w-md">
+            <DialogContent aria-describedby="cron-dialog" className="max-w-md">
                 <DialogTitle className="text-xl font-semibold mb-4">
                     Enter Cron Expression
                 </DialogTitle>
diff --git a/ui/admin/app/components/knowledge/KnowledgeSourceDetail.tsx b/ui/admin/app/components/knowledge/KnowledgeSourceDetail.tsx
index df1c3263b..20c30fc65 100644
--- a/ui/admin/app/components/knowledge/KnowledgeSourceDetail.tsx
+++ b/ui/admin/app/components/knowledge/KnowledgeSourceDetail.tsx
@@ -20,7 +20,12 @@ import KnowledgeSourceAvatar from "~/components/knowledge/KnowledgeSourceAvatar"
 import OauthSignDialog from "~/components/knowledge/OAuthSignDialog";
 import { LoadingSpinner } from "~/components/ui/LoadingSpinner";
 import { Button } from "~/components/ui/button";
-import { Dialog, DialogContent, DialogTitle } from "~/components/ui/dialog";
+import {
+    Dialog,
+    DialogContent,
+    DialogDescription,
+    DialogTitle,
+} from "~/components/ui/dialog";
 import {
     DropdownMenu,
     DropdownMenuCheckboxItem,
@@ -122,6 +127,10 @@ export const KnowledgeSourceDetail: FC<KnowledgeSourceDetailProps> = ({
                 onScroll={handleScroll}
                 ref={tableContainerRef}
             >
+                <DialogDescription hidden>
+                    Knowledge Source Detail
+                </DialogDescription>
+
                 <DialogTitle className="flex justify-between items-center">
                     <div className="flex flex-row items-center">
                         <KnowledgeSourceAvatar
diff --git a/ui/admin/app/hooks/knowledge/useKnowledgeSourceFiles.ts b/ui/admin/app/hooks/knowledge/useKnowledgeSourceFiles.ts
index 6837cb4d4..da3c74550 100644
--- a/ui/admin/app/hooks/knowledge/useKnowledgeSourceFiles.ts
+++ b/ui/admin/app/hooks/knowledge/useKnowledgeSourceFiles.ts
@@ -20,7 +20,10 @@ export function useKnowledgeSourceFiles(
         if (blockPollingFiles) setBlockPollingFiles(false);
     };
 
-    if (knowledgeSource.state === KnowledgeSourceStatus.Syncing) {
+    if (
+        knowledgeSource.state === KnowledgeSourceStatus.Syncing ||
+        knowledgeSource.state === KnowledgeSourceStatus.Pending
+    ) {
         startPolling();
     }