Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action that assigns reviewers when equivalent class axioms are updated #3425

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

matentzn
Copy link
Contributor

The main use case for this action is to provide a way to assign specific reviewers when equivalent class axioms are added or updated, but it should be easy to extend the action to other kinds of edits, hence the generic name.

To achieve the above, we check the diff for changes to rows that signify a logical definition, i.e. starting with "intersection_of". If we find such a change, we set a special environment variable to "true"; if it is "true", in the next step, a reviewer is assigned. Lastly, we let the GitHub action itself make a review, which requests changes - the idea is that these need to be dismissed by a person which sufficient access to Uberon before the change is committed to the main (master) branch.

Issue: #2020

… are updated

The main use case for this action is to provide a way to assign specific reviewers when equivalent class axioms are added or updated, but it should be easy to extend the action to other kinds of edits, hence the generic name.

To achieve the above, we check the diff for changes to rows that signify a logical definition, i.e. starting with "intersection_of". If we find such a change, we set a special environment variable to "true"; if it is "true", in the next step, a reviewer is assigned. Lastly, we let the GitHub action itself make a review, which requests changes - the idea is that these need to be dismissed by a person which sufficient access to Uberon before the change is committed to the main (master) branch.

Issue: #2020
Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve on a technical basis. The PR implements the behaviour you and I agreed upon when discussing the original issue.

But as to whether the behaviour is the one we actually want for Uberon, it’s up to Uberon “senior editors“ and especially @cmungall (who opened #2020) to say.

@matentzn
Copy link
Contributor Author

Thanks! If you see an opening in a Uberon call maybe ask there as well, I will try to catch Chris attention

@cmungall
Copy link
Member

LGTM. I cannot promise to monitor and respond in a timely fashion to these review requests, but having me be assigned is still a useful signal, and if people do not mind prodding me e.g. on slack I think this is a good workflow.

@matentzn matentzn merged commit 3968fec into master Nov 15, 2024
@matentzn matentzn deleted the matentzn-patch-1 branch November 15, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants