-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the source of truth for HubMaps HRA subset to Uberon itself #3037
Comments
Similar to a719af2 |
The subset is generated during a validation pipeline in the HuBMAP repository. It would be harder to keep the subset updated, but I can do it. |
Maybe before you do it, decide on a strategy with your hubmap colleagues on this.. And the rest of the Uberon team! Maybe I am overreacting here, and having an externally maintained dependency is ok. |
The EBI team manages this subset, so it's Aleix and me only. |
So this pipeline, how complex is it? can it run in a GitHub action? |
It's simple but needs to grab the terms from 30+ spreadsheet tables, etc. Everything is done in a GH Action every week now. |
Ok leave it as is then.. I don't want the uberon pipeline to be more complex than necessary now that it has been simplified so nicely! Lets close this issue and thanks for the explanations! |
I want to add this in the odk config file, but it's not working correctly now. I need to check this later. |
This is the plan. #2975 |
We have this goal in uberon.Makefile:
This creates a significant dependency of Uberon to a file totally outside of our control.. Look at this example statement. Isnt it a bit risky that some outside consortium is allowed to add taxon constraints which could potentially break the Uberon build? Also, who can tell if this subset goes stale, or moves location (since its not even linked to a PURL.
I vote for the source of truth of this subset to be moved to Uberon, and hubmap developers updating it here.
The text was updated successfully, but these errors were encountered: