Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo/Error] Synonym appears as both exact AND broad or related for the same term #2305

Open
ghost opened this issue Feb 14, 2022 · 13 comments

Comments

@ghost
Copy link

ghost commented Feb 14, 2022

Uberon term
Multiple terms.
For example, https://www.ebi.ac.uk/ols/ontologies/uberon/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FUBERON_0013528 (and other Brodmann area terms).

Bug description
There are several instances where the same synonym is used as both an exact synonym and a broad synonym for the same term. There are also instances where a synonym is annotated as both an exact and related synonym. For example, see UBERON_0013528 Brodmann (1909) area 11:

Screenshot 2022-02-14 at 09 32 34

In this case, the repeated synonyms probably should only be related to the term with the has_exact_synonym relationship.

These examples were discovered by spot checking and may represent a global issue of duplicate synonyms.

@ghost ghost self-assigned this Feb 14, 2022
@shawntanzk
Copy link
Collaborator

Suggestion:
whenever there is exact and something else - prefer something else? eg broad preferred
When people come by any terms that they don't think is right, they should make a ticket

@shawntanzk
Copy link
Collaborator

https://github.com/monarch-initiative/mondo/tree/master/src/sparql/update <- can use SPARQL query from here and modify.
Discuss in next CL/UBERON call and make decision on this

@ghost
Copy link
Author

ghost commented Feb 21, 2022

whenever there is exact and something else - prefer something else? eg broad preferred

In the example that prompted this ticket, the exact duplicate synonyms should be retained and the broad and related synonyms removed.

@paolaroncaglia
Copy link
Contributor

Also see #2053

@shawntanzk
Copy link
Collaborator

Action: change all to exact and create a PR for review

@ghost
Copy link
Author

ghost commented Apr 19, 2022

Checking in on the status of this... not sure what "Icebox" is.
Will the synonyms in question have to be fixed manually?

@shawntanzk
Copy link
Collaborator

shawntanzk commented Apr 19, 2022

@bvarner-ebi - its in icebox as it depends on discussions here #2363 will put it in the agenda for cl/uberon call

good job past Shawn, apparently already added it to agenda heh

@anitacaron anitacaron removed their assignment Jun 6, 2022
@ghost ghost added the blocked blocked by another issue label Aug 18, 2022
@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Feb 15, 2023
@anitacaron
Copy link
Collaborator

@github-actions github-actions bot removed the Stale label Feb 16, 2023
@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Aug 16, 2023
@ghost
Copy link
Author

ghost commented Oct 18, 2023

Blocked by:

@anitacaron, since the issue noted above is closed I removed the "blocked" label from this issue.
Is there anything else that is required before getting this issue fixed?

@ghost ghost removed the blocked blocked by another issue label Oct 18, 2023
@github-actions github-actions bot removed the Stale label Oct 19, 2023
@ghost
Copy link
Author

ghost commented Nov 17, 2023

No action plan described.
@anitacaron, please consider reassigning as appropriate.

@ghost ghost removed their assignment Nov 17, 2023
@anitacaron
Copy link
Collaborator

The previous PR that tried to fix it ran two SPARQL update queries on uberon-edit.obo. It might take many hours to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants