Adds getAllInternetPasswordServers method for iOS #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
suggested changes
Jul 13, 2021
| for (id entry in result) { | ||
| NSMutableData *serverData = [entry objectForKey:(__bridge NSString *)kSecAttrServer]; | ||
| if (serverData != NULL) { | ||
| NSString *server = [[NSString alloc] initWithData:serverData encoding:NSUTF8StringEncoding]; |
There was a problem hiding this comment.
Suggested change
| NSString *server = [[NSString alloc] initWithData:serverData encoding:NSUTF8StringEncoding]; |
| result = (__bridge NSArray*)(resultRef); | ||
| if (result != NULL) { | ||
| for (id entry in result) { | ||
| NSMutableData *serverData = [entry objectForKey:(__bridge NSString *)kSecAttrServer]; |
There was a problem hiding this comment.
Suggested change
| NSMutableData *serverData = [entry objectForKey:(__bridge NSString *)kSecAttrServer]; | |
| NSString *serverData = [entry objectForKey:(__bridge NSString *)kSecAttrServer]; |
enahum
suggested changes
Jul 13, 2021
| for (id entry in result) { | ||
| NSMutableData *serverData = [entry objectForKey:(__bridge NSString *)kSecAttrServer]; | ||
| if (serverData != NULL) { | ||
| NSString *server = [[NSString alloc] initWithData:serverData encoding:NSUTF8StringEncoding]; |
There was a problem hiding this comment.
Suggested change
| NSString *server = [[NSString alloc] initWithData:serverData encoding:NSUTF8StringEncoding]; |
| NSMutableData *serverData = [entry objectForKey:(__bridge NSString *)kSecAttrServer]; | ||
| if (serverData != NULL) { | ||
| NSString *server = [[NSString alloc] initWithData:serverData encoding:NSUTF8StringEncoding]; | ||
| [servers addObject:server]; |
There was a problem hiding this comment.
Suggested change
| [servers addObject:server]; | |
| [servers addObject:serverData]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how
getAllGenericPasswordServicesreturns a list of services,getAllInternetPasswordServersreturns the list ofkSecAttrServervalues used with internet credentials on iOS.