Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberFormatException in empty-object #176

Open
yegor256 opened this issue Dec 26, 2024 · 7 comments
Open

NumberFormatException in empty-object #176

yegor256 opened this issue Dec 26, 2024 · 7 comments
Assignees
@h1alexbel
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yegor256
Copy link
Member 

Caused by: java.lang.NumberFormatException: For input string: "60.50.301"
    at java.lang.NumberFormatException.forInputString (NumberFormatException.java:67)
    at java.lang.Integer.parseInt (Integer.java:662)
    at java.lang.Integer.parseInt (Integer.java:778)
    at org.eolang.lints.LtByXsl.lineno (LtByXsl.java:144)
    at org.eolang.lints.LtByXsl.defects (LtByXsl.java:111)
    at org.eolang.lints.LtByXsl.defects (LtByXsl.java:45)
    at org.eolang.lints.Program.defects (Program.java:102)

also

IllegalStateException: Wrong line number reported by empty-object: '60.50.301'
    at org.eolang.lints.LtByXsl.lineno (LtByXsl.java:147)
    at org.eolang.lints.LtByXsl.defects (LtByXsl.java:111)
    at org.eolang.lints.LtByXsl.defects (LtByXsl.java:45)
    at org.eolang.lints.Program.defects (Program.java:102)
@yegor256 yegor256 added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Dec 26, 2024
@yegor256
Copy link
Member Author

@h1alexbel maybe you can help? it's a blocker, since we can't use lints 0.0.27 in EO: objectionary/eo#3765

@h1alexbel
Copy link
Contributor

@yegor256 yes assign me, please. What is the EO input that causes this NumberFormatException?

@yegor256
Copy link
Member Author

@h1alexbel I believe, this happens when a number of "empty objects" are present in a single XMIR file, but full story is here: https://github.com/objectionary/eo/actions/runs/12502887142/job/34882452877?pr=3765

h1alexbel added a commit to h1alexbel/lints that referenced this issue Dec 27, 2024
@h1alexbel
fix(objectionary#176): tests
16246e1
h1alexbel added a commit to h1alexbel/lints that referenced this issue Dec 27, 2024
@h1alexbel
fix(objectionary#176): line 0 if NaN
258e9af
@h1alexbel h1alexbel mentioned this issue Dec 27, 2024
Merged
h1alexbel added a commit to h1alexbel/lints that referenced this issue Dec 28, 2024
@h1alexbel
fix(objectionary#176): simplified if test
eb320e4
h1alexbel added a commit to h1alexbel/lints that referenced this issue Dec 29, 2024
@h1alexbel
feat(objectionary#176): _lineno
db92595
h1alexbel added a commit to h1alexbel/lints that referenced this issue Dec 29, 2024
@h1alexbel
feat(objectionary#176): move to lint funcs
bb606b9
h1alexbel added a commit to h1alexbel/lints that referenced this issue Dec 29, 2024
@h1alexbel
feat(objectionary#176): use eo:lineno(@line)
6ce0b75
h1alexbel added a commit to h1alexbel/lints that referenced this issue Dec 29, 2024
@h1alexbel
feat(objectionary#176): no underscore, import to all sheets
0397a0f
yegor256 added a commit that referenced this issue Dec 29, 2024
@yegor256
Merge pull request #181 from h1alexbel/176
69289b8 
fix(#176): set line to '0' in `empty-object` if `@line` is weird
@h1alexbel
Copy link
Contributor

@yegor256 can we release new version?

@yegor256
Copy link
Member Author

@rultor release, tag is 0.0.29

@rultor
Copy link
Contributor

rultor commented Dec 30, 2024

@rultor release, tag is 0.0.29

@yegor256 OK, I will release it now. Please check the progress here.

@rultor
Copy link
Contributor

rultor commented Dec 30, 2024

@rultor release, tag is 0.0.29

@yegor256 Done! FYI, the full log is here (took me 11min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h1alexbel h1alexbel

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @rultor @h1alexbel