Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlClassProperties.java:35-43: Improve Encapsulation of... #636

Closed
0pdd opened this issue Jul 7, 2024 · 2 comments · Fixed by #696
Closed

XmlClassProperties.java:35-43: Improve Encapsulation of... #636

0pdd opened this issue Jul 7, 2024 · 2 comments · Fixed by #696
Assignees
Labels
soon This issue will be solved soon

Comments

@0pdd
Copy link

0pdd commented Jul 7, 2024

The puzzle 627-e9cbafe1 from #627 has to be resolved:

* @todo #627:30min Improve Encapsulation of XmlClassProperties.
* Currently we are exposing many methods like:
* - {@link XmlClassProperties#access()}
* - {@link XmlClassProperties#signature()}
* - {@link XmlClassProperties#supername()}
* - {@link XmlClassProperties#interfaces()}
* They are some sort of getters. This encapsulation violation tells us about poor design.
* We need to hide this methods and provide a better way to access this properties.
* Most probably the problem is deeper than just hiding the methods. We need to rethink the design.

The puzzle was created by rultor on 07-Jul-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@volodya-lombrozo volodya-lombrozo self-assigned this Sep 5, 2024
@volodya-lombrozo volodya-lombrozo added the soon This issue will be solved soon label Sep 5, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 6, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 7, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 7, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 7, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 7, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 7, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Sep 9, 2024
@0pdd
Copy link
Author

0pdd commented Sep 9, 2024

@0pdd the puzzle #697 is still not solved.

@0pdd
Copy link
Author

0pdd commented Sep 13, 2024

@0pdd the only puzzle #697 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soon This issue will be solved soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants