Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnphiMojo must optimize XMIR files too #2729

Closed
yegor256 opened this issue Dec 25, 2023 · 13 comments
Closed

UnphiMojo must optimize XMIR files too #2729

yegor256 opened this issue Dec 25, 2023 · 13 comments
Assignees
Labels

Comments

@yegor256
Copy link
Member

At the moment, the result XMIR's coming out of UnphiMojo contain method attributes. Let's make sure they don't.

@yegor256
Copy link
Member Author

@maxonfjvipon please, help with this one, it's pretty urgent, it blocks objectionary/eo-phi-normalizer#3

@yegor256
Copy link
Member Author

yegor256 commented Dec 25, 2023

@maxonfjvipon I believe, we should introduce a new unit test, which will take some .eo program, parse it to .xmir (using ParseMojo + OptimizeMojo) and then print the XMIR with the help of XMIR class from eo-parse. Then, it will take the XMIR and transfer it to .phi (using PhiMojo), then to .xmir (using UnphiMojo), and then print it with the help of the same XMIR class from eo-parse. The two printed EO programs must be the same, I believe.

@maxonfjvipon
Copy link
Member

@yegor256 in most cases they will be different:
EO:

[x] > main
  x > y

XMIR:

<o name='main'>
  <o name='x'/>
  <o name='y' base='x' ref='...'/>
</o>

phi:

{main -> [x -> ∅, y -> ξ.x]}

unphi:

<o name='main'>
  <o name='x'/>
  <o base='$'/>
  <o name='y' base='x' method=''/>
</o>

@yegor256
Copy link
Member Author

@maxonfjvipon OK, let's make this test:

  • EO to XMIR (via ParseMojo + OptimizeMojo)
  • XMIR to PHI (via PhiMojo)
  • PHI to XMIR (via UnphiMojo)
  • XMIR to EO (via XMIR)
  • assert that EO is parseable (via ParseMojo)

maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 26, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 26, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 26, 2023
@0pdd
Copy link

0pdd commented Dec 27, 2023

@yegor256 the puzzle #2737 is still not solved.

@0pdd
Copy link

0pdd commented Dec 28, 2023

@yegor256 the only puzzle #2737 is solved here.

maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Dec 28, 2023
@0pdd
Copy link

0pdd commented Dec 28, 2023

@yegor256 the puzzle #2750 is still not solved; solved: #2737.

@yegor256
Copy link
Member Author

@rultor release, tag is 0.34.2

@rultor
Copy link
Contributor

rultor commented Dec 28, 2023

@rultor release, tag is 0.34.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Dec 28, 2023

@rultor release, tag is 0.34.2

@yegor256 Done! FYI, the full log is here (took me 32min)

@0pdd
Copy link

0pdd commented Jan 15, 2024

@yegor256 2 puzzles #2779, #2780 are still not solved; solved: #2737, #2750.

@0pdd
Copy link

0pdd commented Jan 16, 2024

@yegor256 the puzzle #2779 is still not solved; solved: #2737, #2750, #2780.

@0pdd
Copy link

0pdd commented Jan 17, 2024

@yegor256 all 4 puzzles are solved here: #2737, #2750, #2779, #2780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants