Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues related to LaTeX #598

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix issues related to LaTeX #598

merged 4 commits into from
Dec 4, 2024

Conversation

eyihluyc
Copy link
Member

@eyihluyc eyihluyc commented Dec 4, 2024

Addresses #595, #596, #599

  • Make LaTeX output parseable when --chain is not used
  • When there are several chains, print messages that enumerate them
  • Add trailing \trans in chains

@eyihluyc eyihluyc requested review from fizruk and deemp December 4, 2024 12:09
Comment on lines 659 to 661
logStrLn "\\begin{phiquation*}"
logStrLn . toLatexString $ logEntryLog (head (head uniqueResults))
logStrLn "\\end{phiquation*}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines can be moved into a separate function parameterized by a String. The function can be reused in the chain && latex case.

Comment on lines 651 to 658
logStrLn
[fmtTrim|
% {ruleSetTitle}

\\documentclass{{article}}
\\usepackage{{eolang}}
\\begin{{document}}
|]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines together with the line that prints "\n\end{document}" can be moved into a separate function parameterized by an IO action. The function can be reused in the chain && latex case.

@eyihluyc eyihluyc requested a review from deemp December 4, 2024 15:49
transitions
unless (length uniqueResults == 1) $
logStrLn $
"\nThis is the " <> unpack (toOrdinal index) <> " possible chain of normalizing rewritings:\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use fmt here too.

@eyihluyc eyihluyc changed the title Make latex output complete (parseable) Fix issues relates to LaTeX Dec 4, 2024
@eyihluyc eyihluyc changed the title Fix issues relates to LaTeX Fix issues related to LaTeX Dec 4, 2024
@eyihluyc eyihluyc requested a review from deemp December 4, 2024 17:46
@deemp deemp merged commit d80d8b9 into master Dec 4, 2024
8 checks passed
@deemp deemp mentioned this pull request Dec 5, 2024
@0crat
Copy link

0crat commented Dec 6, 2024

@eyihluyc Great contribution! 🎉 You've earned +4 points: +4 base, -4 for minimal comments, +4 bonus. Your total is now +4. Keep up the excellent work and remember to include more comments next time!

@0crat
Copy link

0crat commented Dec 6, 2024

@deemp Hey there! 👋 Great job on the review! You've snagged +4 points this time. Here's the breakdown: +4 base points, -10 for having just 3 comments (policy suggests at least 6), and +10 to keep you motivated. Remember, more comments can boost your score next time! Your running balance is now at +52. Keep up the good work and aim for those bonus points! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants