-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues related to LaTeX #598
Conversation
eo-phi-normalizer/app/Main.hs
Outdated
logStrLn "\\begin{phiquation*}" | ||
logStrLn . toLatexString $ logEntryLog (head (head uniqueResults)) | ||
logStrLn "\\end{phiquation*}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines can be moved into a separate function parameterized by a String
. The function can be reused in the chain && latex
case.
eo-phi-normalizer/app/Main.hs
Outdated
logStrLn | ||
[fmtTrim| | ||
% {ruleSetTitle} | ||
|
||
\\documentclass{{article}} | ||
\\usepackage{{eolang}} | ||
\\begin{{document}} | ||
|] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines together with the line that prints "\n\end{document}" can be moved into a separate function parameterized by an IO action. The function can be reused in the chain && latex
case.
eo-phi-normalizer/app/Main.hs
Outdated
transitions | ||
unless (length uniqueResults == 1) $ | ||
logStrLn $ | ||
"\nThis is the " <> unpack (toOrdinal index) <> " possible chain of normalizing rewritings:\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to use fmt
here too.
@deemp Hey there! 👋 Great job on the review! You've snagged +4 points this time. Here's the breakdown: +4 base points, -10 for having just 3 comments (policy suggests at least 6), and +10 to keep you motivated. Remember, more comments can boost your score next time! Your running balance is now at +52. Keep up the good work and aim for those bonus points! 💪 |
Addresses #595, #596, #599
--chain
is not used\trans
in chains