Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to yegor.yaml or built-in rules until new.yaml rules work #618

Closed
3 tasks
deemp opened this issue Dec 6, 2024 · 0 comments · Fixed by #619
Closed
3 tasks

Switch to yegor.yaml or built-in rules until new.yaml rules work #618

deemp opened this issue Dec 6, 2024 · 0 comments · Fixed by #619
Assignees

Comments

@deemp
Copy link
Member

deemp commented Dec 6, 2024

Details

Currently, there's infinite recursion on some tests when using the new rules set.

We assume that the set is problematic. The fixes to the rules aren't straightforward, so the amount of work to fix them is unknown.

Hence, we're going to temporarily use the old rules set.

We should make old rules work with tests for EO 0.41.2 because testing with EO 0.38.4 is currently impossible because it's not on the list of available tags (#527 (comment)).

Currently, the old rules work when some tests are disabled (#527 (comment)).

However, currently, for some reason, more tests should be disabled than in #528.

Subtasks

  • Investigate why more tests should be disabled
  • Update atoms
  • Switch to built-in rules
@deemp deemp self-assigned this Dec 6, 2024
@deemp deemp linked a pull request Dec 6, 2024 that will close this issue
@deemp deemp changed the title Switch to yegor.yaml until new.yaml rules work Switch to yegor.yaml or built-in rules until new.yaml rules work Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant