Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there anywhere a collection of tests for the input grammar? #562

Open
yegor256 opened this issue Nov 26, 2024 · 3 comments
Open

is there anywhere a collection of tests for the input grammar? #562

yegor256 opened this issue Nov 26, 2024 · 3 comments

Comments

@yegor256
Copy link
Member

I'm not sure whether this grammar is valid: https://github.com/objectionary/eo-phi-normalizer/blob/master/eo-phi-normalizer/grammar/EO/Phi/Syntax.cf How can I make sure it is? Do you have a list of test files, both for positive testing (they all should be parseable) and negative (they all should lead to parsing errors)?

@yegor256
Copy link
Member Author

@deemp please, check

@deemp
Copy link
Member

deemp commented Nov 26, 2024

Do you have a list of test files, both for positive testing (they all should be parseable) and negative (they all should lead to parsing errors)?

@yegor256, no, we don't have such a collection.

Do you have one to check that eoc phi and eoc unphi produce and parse only valid phi-expressions?

@yegor256
Copy link
Member Author

@deemp of course, here, and here, and here (for EO syntax). It's helpful for catching bugs earlier, at the level of syntax. Simply adding a file to any of these directories automatically puts it into the testing pipeline.

I've also added positive and negative test packs for phi (maybe you can reuse them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants