Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on all rule sets #447

Open
3 tasks
deemp opened this issue Jul 24, 2024 · 0 comments · May be fixed by #465
Open
3 tasks

Run tests on all rule sets #447

deemp opened this issue Jul 24, 2024 · 0 comments · May be fixed by #465
Assignees
@deemp
Labels
(dataization) Related to dataization (normalization rules) Related to normalization rules (normalizer) Related to the normalizer application (tests) Related to tests
Milestone
[S14] Polish vers...

Comments

@deemp
Copy link
Member

deemp commented Jul 24, 2024 •
edited
Loading

Details

Context

There are two rule sets (implementations of Yegor's rules):

  1. yegor.yaml
  2. built-in rules via fastYegorInsideOut

Problem

Currently, we don't run tests for built-in rules.

Solution

Run tests with built-in rules after running them with yegor.yaml rules.

Subtasks
@deemp deemp self-assigned this Jul 24, 2024
@deemp deemp added (dataization) Related to dataization (normalizer) Related to the normalizer application (normalization rules) Related to normalization rules (tests) Related to tests labels Jul 24, 2024
@deemp deemp changed the title Support choosing a rule set in tests Run tests on all rule sets Jul 25, 2024
@fizruk fizruk mentioned this issue Jul 25, 2024
Closed
@fizruk fizruk added this to the [S14] Polish version 1.x milestone Jul 25, 2024
@deemp deemp linked a pull request Aug 2, 2024 that will close this issue
Open
@deemp deemp linked a pull request Aug 2, 2024 that will close this issue
447 run tests on all rule sets #465
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deemp deemp

Labels
(dataization) Related to dataization (normalization rules) Related to normalization rules (normalizer) Related to the normalizer application (tests) Related to tests
Projects
None yet
Milestone
[S14] Polish version 1.x
Development

Successfully merging a pull request may close this issue.

447 run tests on all rule sets objectionary/eo-phi-normalizer
2 participants
@fizruk @deemp