Fix filtering behavior within non-existent @optional
blocks.
#697
+3,035
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous update to #692, just for filtering instead of type coercion.
We used to attempt to apply filters to the contents of an
@optional
block when the@optional
edge did not exist. This is semantically incorrect behavior — it makes the combination of filters and@optional
useless since the optional results always get discarded when the@optional
edge doesn't exist.This PR reproduces the problem in a variety of settings, and fixes all of them.