Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generality of class "device" #1626

Open
Bayesianworld opened this issue Nov 5, 2022 · 28 comments
Open

generality of class "device" #1626

Bayesianworld opened this issue Nov 5, 2022 · 28 comments
Assignees
@ddooley
Labels
coord:COB migration

Comments

@Bayesianworld
Copy link

I am working with a group developing an ontology for radiation therapy. We are trying to incorporate as many existing classes as possible. OBI_0000968 "device", the definition states:
A material entity that is designed to perform a function in a scientific investigation, but is not a reagent."

We would like to use this class but cannot use if if it only covers devices in a "scientific investigation". We are clinically oriented and do not always operate in the investigation mode (though sometimes we do). Is there any interest in making this class more general?

Mark Phillips
University of Washington
[email protected]
@bpeters42
Copy link
Contributor

bpeters42 commented Nov 6, 2022 via email

@ddooley
Copy link
Contributor

ddooley commented Nov 26, 2022

I'll see if we can make this an item on next OBI call. Seems to me the simplest move is to change OBI "device" to "scientific device" given the definition. And add a new COB term "device".

@DanBerrios
Copy link
Contributor

@Bayesianworld Be sure to check out OBO RBO. If you want to collaborate, let us know... https://github.com/Radiobiology-Informatics-Consortium/RBO

@DanBerrios
Copy link
Contributor

Discussed on OBI Call 11/28:

  1. COB should model "general device": a processed material that performs a function
  2. Obsolete OBI:device
  3. Replace with COB:"general device"
  4. Move all current OBI:device classes to replacement COB:general device

@Bayesianworld This is our plan for widening the scope of OBI:device subclasses...will this meet your needs?

@ddooley ddooley self-assigned this Nov 28, 2022
@ddooley
Copy link
Contributor

ddooley commented Nov 28, 2022

@DanBerrios One thing I missed - I'd thought new COB term was going to literally be called "device", rather than "general device". Seems odd to have an upper level "general [x]" labeled class, and then have more specific labeled classes under it?!

@linikujp
Copy link

For your reference, the FDA definition of "device" is codified in section 201 of the FD&C Act.

The term “device” (except when used in paragraph (n) of this section and in
sections 301(i), 403(f), 502(c), and 602(c)) means an instrument, apparatus, implement,
machine, contrivance, implant, in vitro reagent, or other similar or related article,
including any component, part, or accessory, which is—
(A) recognized in the official National Formulary, or the United States Pharmacopeia, or any supplement to them,
(B) intended for use in the diagnosis of disease or other conditions, or in the cure,
mitigation, treatment, or prevention of disease, in man or other animals, or
(C) intended to affect the structure or any function of the body of man or other
animals, and which does not achieve its primary intended purposes through chemical action within or on the body of man or other animals and which is not dependent upon being metabolized for the achievement of its primary intended purposes. The term “device” does not include software functions excluded pursuant to section 520(o).
(https://www.fda.gov/media/154866/download)

The wikipedia may cover a better definition for medical device (https://en.wikipedia.org/wiki/Medical_device)

General device in wikipedia: https://en.wikipedia.org/wiki/Device

@ddooley
Copy link
Contributor

ddooley commented Nov 29, 2022 •
edited
Loading

@linikujp it looks like you need a "medical device" or "regulated device" subclass? We need a general "device" parent term that allows for use other than in a medical role. "medical device" etc. can be classed under device.

@linikujp
Copy link

linikujp commented Nov 29, 2022 •
edited
Loading

@ddooley to clarify, this definition is for your or COB group's reference to define a general device with reasonable solutions within the reasonable domain. For example, an ambulance can be a device used for medical purpose, but not my car. When you create this general device term, how will you treat terms like that? This is just for your consideration. After the general term is created, I will create a medical device as its child.

Besides, I have some general links from the wiki provided in my message...

Thanks,
Asiyah

@Bayesianworld
Copy link
Author

Glad to see the in-depth discussion. For our part (radiation therapy ontology), we are currently satisfied to put a bunch of different devices directly under the OBI or COB "device" or "general device". These include pretty specific devices such as collimators, patient positioning devices, imaging device and radiation therapy device. Each of these may have more specific children as needed. Is there a need to interpose a "medical device" between a "general device" for these classes?

@linikujp
Copy link

linikujp commented Nov 30, 2022 via email

@ddooley
Copy link
Contributor

ddooley commented Nov 30, 2022

This was touched on in the OBI call. A thought is that it would be best to group devices by their functionality.

One could also define "regulated device" , "regulated medical device" which is about devices that have regulatory requirements attached to them (legislated licensing or performance specifications). Kind of hard to axiomatize that right now. This could be specialized into the various jurisdictions if desired. But these classes would remain unpopulated.

@ddooley
Copy link
Contributor

ddooley commented Dec 5, 2022

I am following up with COB about defining "device" there, and OBI will then import this new term.

@bpeters42
Copy link
Contributor

@ddooley, can you please create a definition etc. to discuss and then make a PR? Happy to also discuss with you offline.

@ddooley
Copy link
Contributor

ddooley commented Dec 6, 2022 •
edited
Loading

In this definition we assume devices are made of processed material, not natural artifacts, so we involve artifactual function rather than biological function, but align with a general BFO function sense where functions such as pumping, lifting occur in both contexts. Thus we can compare a biological arm with a robotic arm device.

COB device (because COB label's OBI "processed material" as "processed material entity") can be :

device: A processed material entity which is designed to perform a function.

This covers both "whole" devices like an engine, and components like a bolt. Rather than "is designed to perform a function" we could say "is designed to bear a function". It seems we have to put in the "designed" part to emphasize a devices primary function vs all the other possible dispositions a device may have that may also be useful. E.g. I can use a hammer for a paper weight. We can't now say a naturally formed rock is a hammering device - it doesn't have a hammering function per se.

(A side discussion is whether "tool" is device's more creative, disposition-rather-than-necessarily-function-bearing counterpart. Perhaps a device - or anything - is a tool if used for some disposition other than its function. A rock might be a hammering tool if it has a hammering disposition.)

(There is a psychological sense of device as ploy - "His temper tantrums were just a device for attracting attention." but we'll leave "psychological device" to be defined by behavioural science folks).

@bpeters42 happy to chat about this towards end of week! I'll move this over to a COB pull request after some feedback.

@Bayesianworld
Copy link
Author

Referring to the earlier comments about whether it would be useful to include subclasses such as "medical" or "regulated" device. My question is perhaps a bit to fine, but is it better to make a subclass that is based on its intended use or its inherent function. As an example, agricultural and medical devices might both include a pump. In the spirit of making an ontology useful, it would seem that defining first a "pump device" and then further dividing into medical and agricultural devices would add a lot of unnecessary clutter. So I would be inclined to the first approach, but just thought I would check to see if there was a better alternative.

@ddooley
Copy link
Contributor

ddooley commented Dec 6, 2022

It seems wise to have a generic functional hierarchy of devices, and place more specific devices under that. It would be nice to have a "medical device" class that could have subclasses inferred under it though by virtue of having some "regulated device role". And maybe some "precomposed" subclasses such as "medical pump" for convenience. Hmm!

@bpeters42
Copy link
Contributor

Damion, I like your definition as proposed. It would be good to capture the other points you are making not as a loose discussion, but rather as examples, elucidations etc. that we can include in the COB term. The logical definition seems obvious from the textual: 'processed material' and 'has characteristic' some function.

I also think we should in parallel spell out how we expect devices to be used. We have the long form with 2 logical statements:

'completely executed planned process' and 'has specified input' some device
'completely executed planned process' and realizes some (function and ('characteristic of' some device))

And we have previously talked about wanting to have a 'utilizes device' relationship. That should be a shortcut that expands to the two above, and is between a planned process and the device. We could have a definition like; 'utilizes device' is a relationship between a planned process and a device, where the device is an input to the planned process and a function of the device is used as part of the planned process.

@ddooley
Copy link
Contributor

ddooley commented Dec 8, 2022 •
edited
Loading

Yay!

**label: device**
**definition:** A processed material entity which is designed to perform a function.
**example of usage:** A whole device like an engine; a component like a bolt.
**comment**: 

In this definition we assume devices are made of processed material, not natural artifacts, so we involve artifactual function rather than biological function, but align with a general BFO function sense where functions such as pumping, lifting occur in both contexts. Thus we can compare a biological arm with a robotic arm device. 

We say "designed" to emphasize a devices primary function vs all the other possible dispositions a device may have that may also be useful. E.g. one can use a hammer for a paper weight. We can't now say a naturally formed rock is a **hammering device** - it wasn't **designed** to bear a hammering function per se. However, a given rock may still happen to have the disposition to bear a hammering function, and so be used as a tool for that.

Currently "capable of/ capable of part of/ enables" are RO relations attaching devices to processes.

image

I see how a device could be considered an input to a process; but also how a device - like a robot (an agent) - is a participant in a process. So yes its still a bit wishy-washy there. A human even, is a device for carying out some processes like writing in the sand. Clarifications?

@linikujp
Copy link

linikujp commented Dec 8, 2022 via email

@ddooley
Copy link
Contributor

ddooley commented Dec 8, 2022 •
edited
Loading

About human - my bad, right you are! And I see that robot counts as device.
Given that "capable of/ capable of part of/ enables" can connect devices including robots to processes, do we drop:

'completely executed planned process' and 'has specified input' some device

Also, not all executed planned processes need devices. I can shape dough with my hands, but I am not a device. (I use my hands as tools though.)

Do we also want "has performer" to point to a robot too, per existing example:
OBI "has performer" has a mistaken annotation BTW - it should be reshaped into a definition and a comment:

term editor:
performer relation covers the need to report on who performed a planned processed. it has to cover processes done by People or Devices (such as a robot controlled by software WF management system)

Or should "has performer" be tweaked to reference only entities that can be considered to bear responsibility/intentionality for seeing a process to completion?

@bpeters42
Copy link
Contributor

has_specified_input is a sub-property of has_participant. So there is no conflict. Humans aren't processed materials, so they are not devices (like Asiyah said as well).

And I don't think we should drop the second statement. We want to list all participants in a planned process. We need both statements because in OWL we can't say that the function being realized is borne by a participants.

Regarding 'capable of' etc., 'utilizes device' is the inverse. I am unclear if there is an existing relationship for that in RO. Note that inverses of shortcut relations are not trivial.

@linikujp
Copy link

linikujp commented Dec 8, 2022 via email

@ddooley
Copy link
Contributor

ddooley commented Dec 8, 2022 •
edited
Loading

@bpeters42 I think I understand now. RO does have
image
that connect between materials (including catalysts and devices) and processes (and these OPs have inverses. "utilizes device" has been deprecated once and for as I recall?)

But aside from saying generally that a device can enable a process, we want at an instance level to say that a particular device, or device type, was a participant in a process. If the convention is to say a device is a kind of input, I can handle that, I just hadn't seen that before.

So an updated diagram is [with update "measurement device"]:
image

Suggestions for "measures" OP label ? And should it have range all characteristics, or just those of material things since assay can only input material things?

@ddooley
Copy link
Contributor

ddooley commented Dec 13, 2022

The "measures" discussion has been moved to: oborel/obo-relations#658

@ddooley ddooley mentioned this issue Dec 15, 2022
Closed
@DanBerrios
Copy link
Contributor

COB has now created a more general device https://ontobee.org/ontology/COB?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FCOB_0001300

Can we import it as a parent of OBI:device? Would we also want to re-label OBI:device as "investigation device"?

@ddooley
Copy link
Contributor

ddooley commented Nov 14, 2023

Sounds good. It will require promoting many subclasses of OBI device up to COB device subclasses since the OBI one has been the catch-all so far. E.g. "apron" and "container" are more general than an "investigation device" would afford.

@DanBerrios
Copy link
Contributor

@ddooley Agreed.

@bpeters42
Copy link
Contributor

bpeters42 commented Nov 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddooley ddooley

Labels
coord:COB migration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DanBerrios @ddooley @linikujp @bpeters42 @Bayesianworld