Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DB/CSV selection in cell_logger #95

Open
facastiblancor opened this issue Oct 2, 2020 · 1 comment
Open

Improve DB/CSV selection in cell_logger #95

facastiblancor opened this issue Oct 2, 2020 · 1 comment
Assignees
@facastiblancor
Labels
enhancement New feature or request
Milestone
0.1.1 Testing

Comments

@facastiblancor
Copy link
Collaborator

Cell logger currently uses an if statement that uses logic to select between CSV and DB logging. This is fragile and is prone to errors. This issue will ensure that a better selection mechanism is chosen. Such as using Click on python:

https://click.palletsprojects.com/en/7.x/options/#values-from-environment-variables
@facastiblancor facastiblancor added the enhancement New feature or request label Oct 2, 2020
@facastiblancor facastiblancor added this to the 0.1.1 Testing milestone Oct 2, 2020
@facastiblancor facastiblancor self-assigned this Oct 2, 2020
@abalmos
Copy link
Member

abalmos commented Jul 13, 2021 •
edited
Loading

Can this be closed? @facastiblancor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facastiblancor facastiblancor

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.1 Testing
Development

No branches or pull requests
2 participants
@abalmos @facastiblancor