Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated validation for Marking Definition #218

Open
james-garriss opened this issue Sep 22, 2023 · 2 comments
Open

Outdated validation for Marking Definition #218

james-garriss opened this issue Sep 22, 2023 · 2 comments

Comments

@james-garriss
Copy link

I am validating a Marking Definition object:

    {
      "type": "marking-definition",
      "id": "marking-definition--de729800-9a18-49bb-a67b-4990bf18ec42",
      "spec_version": "2.1",
      "created": "2023-09-22T14:55:01.812Z",
      "name": "CUI"
    },

And the validator is returning this error:

marking definitions must use the 'definition_type' and 'definition' properties with a valid 
marking definition, or use an extension and the properties it requires

But the current spec says that definition_type and definition have both been deprecated.

https://docs.oasis-open.org/cti/stix/v2.1/os/stix-v2.1-os.html#_k5fndj2c7c1k

I assume this means that the validator needs to be updated to match the current spec.

Thanks!

@clenk
Copy link
Contributor

clenk commented Sep 22, 2023

Those properties are deprecated in 2.1 but not removed. The descriptions of those 2 properties in the marking definition property table you linked to in the spec both say that

If the extensions property is not present, this property MUST be present.

So the marking definition either needs to have the extensions property or both the definition_type and definition properties.

@james-garriss
Copy link
Author

First, thanks for the clarification.

Second, that's so bizarre. What is OASIS trying to communicate here? Are they saying, "We used to have a standard way of representing markings, but we don't really want you to use it any more. Please create your own instead."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants