Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better warning messages for open vocabs and relationship types #211

Open
rpiazza opened this issue Feb 22, 2023 · 2 comments
Open

Better warning messages for open vocabs and relationship types #211

rpiazza opened this issue Feb 22, 2023 · 2 comments

Comments

@rpiazza
Copy link
Contributor

rpiazza commented Feb 22, 2023

Before you were on the working call today, we discussed this issue, which Sean has said he has been asked about.

We thought maybe there could be more "gentle" warning for such messages. Here are some ideas off the top of my head:

's value is permitted, but not in

Relationship type is permitted, but not explicitly defined in the specification

@rpiazza
Copy link
Contributor Author

rpiazza commented Sep 14, 2024

Change the warning message at https://github.com/oasis-open/cti-stix-validator/blob/master/stix2validator/v21/shoulds.py#L539 to say:

'%s' is permitted, but not a suggested relationship type for '%s' objects

and at https://github.com/oasis-open/cti-stix-validator/blob/master/stix2validator/v21/shoulds.py#L390 to say:

"The value contained in %s is permitted, but is not in the %s-ov vocabulary."

@rpiazza
Copy link
Contributor Author

rpiazza commented Sep 14, 2024

use this file to test:

malware-indicator-for-file-hash.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant