Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set pretty=false in FileSystemSink as it is hardcoded as true #561

Open
himynamesdave opened this issue Nov 15, 2022 · 1 comment

Comments

@himynamesdave
Copy link

Currently cannot set the parameter pretty=false using FileSystemSink endpoints.

In that code path - Pretty is hardcoded

with io.open(file_path, mode='w', encoding=encoding) as f:
            fp_serialize(stix_obj, f, pretty=True, encoding=encoding, ensure_ascii=False)

fp_serialize(stix_obj, f, pretty=True, encoding=encoding, ensure_ascii=False)

Other endpoints support this parameter and it is not clear why it is not supported by FileSystemSink

Hence suggestion is to allow boolean variable for pretty for this endpoint.

himynamesdave added a commit to muchdogesec/cti-python-stix2 that referenced this issue Oct 25, 2023
@himynamesdave
Copy link
Author

himynamesdave commented Oct 25, 2023

Also linking the relevant discussion on CTI TC Slack for reference:

https://cti-tc.slack.com/archives/C0DR1QMM3/p1667743171800879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant